github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-23 09:19:04 -04:00
Code Issues Projects Releases Packages Wiki Activity

[Uptime] Overview link to Exploratory View should not filter by monitor (#122907)

Browse source 
* Modify Exploratory View link to prevent filtering by monitor from Overview page.

* Modify route match so only detail page will include monitor name filter on exploratory view link.

* Remove unnecessary comment.
This commit is contained in:
Justin Kambic 2022-01-14 14:39:24 -05:00 • committed by GitHub
parent 5309868bc9
commit 939a642819
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

10
x-pack/plugins/uptime/public/components/common/header/action_menu_content.tsx
View file

@ -9,14 +9,14 @@ import React from 'react';
import { EuiHeaderLinks, EuiToolTip, EuiHeaderLink } from '@elastic/eui';
import { i18n } from '@kbn/i18n';
import { FormattedMessage } from '@kbn/i18n-react';
import { useHistory } from 'react-router-dom';
import { useHistory, useRouteMatch } from 'react-router-dom';
import { useSelector } from 'react-redux';
import { createExploratoryViewUrl } from '../../../../../observability/public';
import { useKibana } from '../../../../../../../src/plugins/kibana_react/public';
import { useUptimeSettingsContext } from '../../../contexts/uptime_settings_context';
import { useGetUrlParams } from '../../../hooks';
import { ToggleAlertFlyoutButton } from '../../overview/alerts/alerts_containers';
import { MONITOR_MANAGEMENT, SETTINGS_ROUTE } from '../../../../common/constants';
import { MONITOR_MANAGEMENT, MONITOR_ROUTE, SETTINGS_ROUTE } from '../../../../common/constants';
import { stringifyUrlParams } from '../../../lib/helper/stringify_url_params';
import { InspectorHeaderLink } from './inspector_header_link';
import { monitorStatusSelector } from '../../../state/selectors';
@ -44,6 +44,7 @@ export function ActionMenuContent({ config }: { config: UptimeConfig }): React.R
const selectedMonitor = useSelector(monitorStatusSelector);
const detailRouteMatch = useRouteMatch(MONITOR_ROUTE);
const monitorId = selectedMonitor?.monitor?.id;
const syntheticExploratoryViewLink = createExploratoryViewUrl(
@ -57,7 +58,10 @@ export function ActionMenuContent({ config }: { config: UptimeConfig }): React.R
time: { from: dateRangeStart, to: dateRangeEnd },
breakdown: monitorId ? 'observer.geo.name' : 'monitor.type',
reportDefinitions: {
'monitor.name': selectedMonitor?.monitor?.name ? [selectedMonitor?.monitor?.name] : [],
'monitor.name':
selectedMonitor?.monitor?.name && detailRouteMatch?.isExact === true
? [selectedMonitor?.monitor?.name]
: [],
'url.full': ['ALL_VALUES'],
},
name: monitorId ? `${monitorId}-response-duration` : 'All monitors response duration',