github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 09:48:58 -04:00
Code Issues Projects Releases Packages Wiki Activity

[RAC][Observability] Use no data screen for the alerts and cases pages (#115178)

Browse source 
Co-authored-by: Chris Cowan <chris@chriscowan.us>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This commit is contained in:
Alejandro Fernández Gómez 2021-10-21 12:54:07 +02:00 • committed by GitHub
parent d2dea6816c
commit 941a6c9bb9
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
8 changed files with 79 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

20
x-pack/plugins/observability/public/pages/alerts/index.tsx
View file

@ -15,9 +15,12 @@ import type { AlertWorkflowStatus } from '../../../common/typings';
import { ExperimentalBadge } from '../../components/shared/experimental_badge';
import { useBreadcrumbs } from '../../hooks/use_breadcrumbs';
import { useFetcher } from '../../hooks/use_fetcher';
import { useHasData } from '../../hooks/use_has_data';
import { usePluginContext } from '../../hooks/use_plugin_context';
import { useTimefilterService } from '../../hooks/use_timefilter_service';
import { callObservabilityApi } from '../../services/call_observability_api';
import { getNoDataConfig } from '../../utils/no_data_config';
import { LoadingObservability } from '../overview/loading_observability';
import { AlertsSearchBar } from './alerts_search_bar';
import { AlertsTableTGrid } from './alerts_table_t_grid';
import { Provider, alertsPageStateContainer, useAlertsPageStateContainer } from './state_container';
@ -137,8 +140,25 @@ function AlertsPage() {
refetch.current = ref;
}, []);
const { hasAnyData, isAllRequestsComplete } = useHasData();
// If there is any data, set hasData to true otherwise we need to wait till all the data is loaded before setting hasData to true or false; undefined indicates the data is still loading.
const hasData = hasAnyData === true || (isAllRequestsComplete === false ? undefined : false);
if (!hasAnyData && !isAllRequestsComplete) {
return <LoadingObservability />;
}
const noDataConfig = getNoDataConfig({
hasData,
basePath: core.http.basePath,
docsLink: core.docLinks.links.observability.guide,
});
return (
<ObservabilityPageTemplate
noDataConfig={noDataConfig}
data-test-subj={noDataConfig ? 'noDataPage' : undefined}
pageHeader={{
pageTitle: (
<>

23
x-pack/plugins/observability/public/pages/cases/all_cases.tsx
View file

@ -16,16 +16,35 @@ import { usePluginContext } from '../../hooks/use_plugin_context';
import { useReadonlyHeader } from '../../hooks/use_readonly_header';
import { casesBreadcrumbs } from './links';
import { useBreadcrumbs } from '../../hooks/use_breadcrumbs';
import { useHasData } from '../../hooks/use_has_data';
import { LoadingObservability } from '../overview/loading_observability';
import { getNoDataConfig } from '../../utils/no_data_config';
export const AllCasesPage = React.memo(() => {
const userPermissions = useGetUserCasesPermissions();
const { ObservabilityPageTemplate } = usePluginContext();
const { core, ObservabilityPageTemplate } = usePluginContext();
useReadonlyHeader();
useBreadcrumbs([casesBreadcrumbs.cases]);
const { hasAnyData, isAllRequestsComplete } = useHasData();
if (!hasAnyData && !isAllRequestsComplete) {
return <LoadingObservability />;
}
// If there is any data, set hasData to true otherwise we need to wait till all the data is loaded before setting hasData to true or false; undefined indicates the data is still loading.
const hasData = hasAnyData === true || (isAllRequestsComplete === false ? undefined : false);
const noDataConfig = getNoDataConfig({
hasData,
basePath: core.http.basePath,
docsLink: core.docLinks.links.observability.guide,
});
return userPermissions == null || userPermissions?.read ? (
<ObservabilityPageTemplate
data-test-subj={noDataConfig ? 'noDataPage' : undefined}
noDataConfig={noDataConfig}
pageHeader={{
pageTitle: <>{i18n.PAGE_TITLE}</>,
}}

7
x-pack/test/functional/page_objects/observability_page.ts
View file

@ -11,7 +11,6 @@ import { FtrProviderContext } from '../ftr_provider_context';
export function ObservabilityPageProvider({ getService, getPageObjects }: FtrProviderContext) {
const testSubjects = getService('testSubjects');
const find = getService('find');
return {
async expectCreateCaseButtonEnabled() {
@ -32,6 +31,10 @@ export function ObservabilityPageProvider({ getService, getPageObjects }: FtrPro
await testSubjects.missingOrFail('case-callout-e41900b01c9ef0fa81dd6ff326083fb3');
},
async expectNoDataPage() {
await testSubjects.existOrFail('noDataPage');
},
async expectCreateCase() {
await testSubjects.existOrFail('case-creation-form-steps');
},
@ -47,7 +50,7 @@ export function ObservabilityPageProvider({ getService, getPageObjects }: FtrPro
},
async expectForbidden() {
const h2 = await find.byCssSelector('body', 20000);
const h2 = await testSubjects.find('no_feature_permissions', 20000);
const text = await h2.getVisibleText();
expect(text).to.contain('Kibana feature privileges required');
},

5
x-pack/test/functional/services/observability/alerts/common.ts
View file

@ -74,6 +74,10 @@ export function ObservabilityAlertsCommonProvider({
return await testSubjects.existOrFail(ALERTS_TABLE_CONTAINER_SELECTOR);
};
const getNoDataPageOrFail = async () => {
return await testSubjects.existOrFail('noDataPage');
};
const getNoDataStateOrFail = async () => {
return await testSubjects.existOrFail('tGridEmptyState');
};
@ -221,6 +225,7 @@ export function ObservabilityAlertsCommonProvider({
getCopyToClipboardButton,
getFilterForValueButton,
copyToClipboardButtonExists,
getNoDataPageOrFail,
getNoDataStateOrFail,
getTableCells,
getTableCellsInRows,

2
x-pack/test/observability_functional/apps/observability/alerts/add_to_case.ts
View file

@ -17,9 +17,11 @@ export default ({ getService, getPageObjects }: FtrProviderContext) => {
before(async () => {
await esArchiver.load('x-pack/test/functional/es_archives/observability/alerts');
await esArchiver.load('x-pack/test/functional/es_archives/infra/metrics_and_logs');
});
after(async () => {
await esArchiver.unload('x-pack/test/functional/es_archives/infra/metrics_and_logs');
await esArchiver.unload('x-pack/test/functional/es_archives/observability/alerts');
});

15
x-pack/test/observability_functional/apps/observability/alerts/index.ts
View file

@ -41,7 +41,22 @@ export default ({ getService }: FtrProviderContext) => {
await esArchiver.unload('x-pack/test/functional/es_archives/observability/alerts');
});
describe('With no data', () => {
it('Shows the no data screen', async () => {
await observability.alerts.common.getNoDataPageOrFail();
});
});
describe('Alerts table', () => {
before(async () => {
await esArchiver.load('x-pack/test/functional/es_archives/infra/metrics_and_logs');
await observability.alerts.common.navigateToTimeWithData();
});
after(async () => {
await esArchiver.unload('x-pack/test/functional/es_archives/infra/metrics_and_logs');
});
it('Renders the table', async () => {
await observability.alerts.common.getTableOrFail();
});

2
x-pack/test/observability_functional/apps/observability/alerts/workflow_status.ts
View file

@ -21,11 +21,13 @@ export default ({ getService }: FtrProviderContext) => {
before(async () => {
await esArchiver.load('x-pack/test/functional/es_archives/observability/alerts');
await esArchiver.load('x-pack/test/functional/es_archives/infra/metrics_and_logs');
await observability.alerts.common.navigateToTimeWithData();
});
after(async () => {
await esArchiver.unload('x-pack/test/functional/es_archives/observability/alerts');
await esArchiver.unload('x-pack/test/functional/es_archives/infra/metrics_and_logs');
});
it('is filtered to only show "open" alerts by default', async () => {

9
x-pack/test/observability_functional/apps/observability/feature_controls/observability_security.ts
View file

@ -31,8 +31,14 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
await esArchiver.unload('x-pack/test/functional/es_archives/cases/default');
});
it('Shows the no data page on load', async () => {
await PageObjects.common.navigateToActualUrl('observabilityCases');
await PageObjects.observability.expectNoDataPage();
});
describe('observability cases all privileges', () => {
before(async () => {
await esArchiver.load('x-pack/test/functional/es_archives/infra/metrics_and_logs');
await observability.users.setTestUserRole(
observability.users.defineBasicObservabilityRole({
observabilityCases: ['all'],
@ -42,6 +48,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
});
after(async () => {
await esArchiver.unload('x-pack/test/functional/es_archives/infra/metrics_and_logs');
await observability.users.restoreDefaultTestUserRole();
});
@ -83,6 +90,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
describe('observability cases read-only privileges', () => {
before(async () => {
await esArchiver.load('x-pack/test/functional/es_archives/infra/metrics_and_logs');
await observability.users.setTestUserRole(
observability.users.defineBasicObservabilityRole({
observabilityCases: ['read'],
@ -92,6 +100,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
});
after(async () => {
await esArchiver.unload('x-pack/test/functional/es_archives/infra/metrics_and_logs');
await observability.users.restoreDefaultTestUserRole();
});