github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 01:38:56 -04:00
Code Issues Projects Releases Packages Wiki Activity

chore(Lens): remove inline editor empty space (#184369)

Browse source 
This PR fixes a style issue in the inline editor.
The issue is visible in the Breakdown -> Advanced configuration where
the Advanced accordion retained its content space even if it was closed.
I cleaned up the style where needed, removing what looked like
unnecessary applied styles (not used anymore after the changes).
This commit is contained in:
Marco Vettorello 2024-06-05 10:30:52 +02:00 • committed by GitHub
parent af1d12cc8a
commit 958072af0c
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 17 additions and 23 deletions
Download patch file Download diff file Expand all files Collapse all files

23
x-pack/plugins/lens/public/app_plugin/shared/edit_on_the_fly/layer_configuration_section.tsx
View file

@ -67,23 +67,16 @@ export function LayerConfiguration({
return (
<div
css={css`
padding-left: ${euiTheme.size.base};
padding-right: ${euiTheme.size.base};
padding: ${hasPadding ? euiTheme.size.s : 0};
`}
>
<div
css={css`
padding: ${hasPadding ? euiTheme.size.s : 0};
`}
>
<EuiSpacer size="xs" />
<VisualizationToolbar
activeVisualization={activeVisualization}
framePublicAPI={framePublicAPI}
/>
<EuiSpacer size="m" />
<ConfigPanelWrapper {...layerPanelsProps} />
</div>
<EuiSpacer size="xs" />
<VisualizationToolbar
activeVisualization={activeVisualization}
framePublicAPI={framePublicAPI}
/>
<EuiSpacer size="m" />
<ConfigPanelWrapper {...layerPanelsProps} />
</div>
);
}

17
x-pack/plugins/lens/public/app_plugin/shared/edit_on_the_fly/lens_configuration_flyout.tsx
View file

@ -434,6 +434,12 @@ export function LensEditConfigurationFlyout({
flex: 1;
}
}
.lnsIndexPatternDimensionEditor-advancedOptions {
.euiAccordion__childWrapper {
flex: none;
overflow: hidden !important;
}
}
`}
direction="column"
gutterSize="none"
@ -477,18 +483,13 @@ export function LensEditConfigurationFlyout({
<EuiFlexItem
grow={isLayerAccordionOpen ? 1 : false}
css={css`
.euiAccordion__childWrapper {
flex: ${isLayerAccordionOpen ? 1 : 'none'}
}
.euiAccordion__childWrapper {
flex: ${isLayerAccordionOpen ? 1 : 'none'};
}
padding: 0 ${euiThemeVars.euiSize};
`}
>
<EuiAccordion
css={css`
.euiAccordion__triggerWrapper {
padding: 0 ${euiThemeVars.euiSize};
}
`}
id="layer-configuration"
buttonContent={
<EuiTitle