[Discover] Remove _type of uiSettings metaFields (#134453)

Remove the deprecated _type of metaFields to prevent from showing up in Discover's sidebar
This commit is contained in:
Matthias Wilhelm 2022-06-17 20:09:25 +02:00 committed by GitHub
parent 62e9b8b956
commit 961b47a08b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
7 changed files with 7 additions and 8 deletions

View file

@ -39,7 +39,7 @@ export function getUiSettings(
name: i18n.translate('data.advancedSettings.metaFieldsTitle', {
defaultMessage: 'Meta fields',
}),
value: ['_source', '_id', '_type', '_index', '_score'],
value: ['_source', '_id', '_index', '_score'],
description: i18n.translate('data.advancedSettings.metaFieldsText', {
defaultMessage:
'Fields that exist outside of _source to merge into our document when displaying it',

View file

@ -32,7 +32,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
const fieldCount = await PageObjects.settings.getFieldsTabCount();
// five metafields plus keyword and text version of 'user' field
expect(parseInt(fieldCount, 10)).to.be(7);
expect(parseInt(fieldCount, 10)).to.be(6);
});
});
}

View file

@ -65,7 +65,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
});
});
describe('field list pagination', function () {
const EXPECTED_FIELD_COUNT = 86;
const EXPECTED_FIELD_COUNT = 85;
it('makelogs data should have expected number of fields', async function () {
await retry.try(async function () {
const TabCount = await PageObjects.settings.getFieldsTabCount();

View file

@ -14,11 +14,10 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
const security = getService('security');
const PageObjects = getPageObjects(['common', 'home', 'settings']);
// FLAKY: https://github.com/elastic/kibana/issues/89031
describe('test large number of fields', function () {
this.tags(['skipCloud']);
const EXPECTED_FIELD_COUNT = '10006';
const EXPECTED_FIELD_COUNT = '10005';
before(async function () {
await security.testUser.setRoles(['kibana_admin', 'test_testhuge_reader']);
await esArchiver.emptyKibanaIndex();

View file

@ -34,7 +34,7 @@ export default function ({ getService }: PluginFunctionalProviderContext) {
indexPatternId = body.id;
expect(body.id).not.empty();
expect(body.title).to.equal(title);
expect(body.fields.length).to.equal(15);
expect(body.fields.length).to.equal(14);
expect(body.fieldFormatMap).to.eql(fieldFormats);
});

View file

@ -14,7 +14,7 @@ const TEST_END_TIME = '2023-09-23T18:31:44.000';
const COMMON_HEADERS = {
'kbn-xsrf': 'some-xsrf-token',
};
const metaFields = ['_id', '_index', '_score', '_source', '_type'];
const metaFields = ['_id', '_index', '_score', '_source'];
const fieldsWithData = [
'ts',

View file

@ -108,7 +108,7 @@ export default function ({ getService, getPageObjects }) {
// ensure all fields are available
await PageObjects.settings.clickIndexPatternByName(rollupIndexPatternName);
const fields = await PageObjects.settings.getFieldNames();
expect(fields).to.eql(['@timestamp', '_id', '_index', '_score', '_source', '_type']);
expect(fields).to.eql(['@timestamp', '_id', '_index', '_score', '_source']);
});
after(async () => {