github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-25 02:09:32 -04:00
Code Issues Projects Releases Packages Wiki Activity

[Accessibility] Spaces List "Roles" Link needs more context #27745 (#36270)

Browse source 
* added aria label
This commit is contained in:
Philipp B 2019-05-13 11:50:25 +03:00 • committed by GitHub
parent ecd19d0bab
commit 965340d6a8
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

1
x-pack/plugins/spaces/public/views/management/components/secure_space_message/__snapshots__/secure_space_message.test.tsx.snap generated
View file

@ -15,6 +15,7 @@ exports[`SecureSpaceMessage renders if user profile allows security to be manage
values={ values={
Object { Object {
"rolesLink": <EuiLink "rolesLink": <EuiLink
aria-label="Roles management page"
color="primary" color="primary"
href="#/management/security/roles" href="#/management/security/roles"
type="button" type="button"

7
x-pack/plugins/spaces/public/views/management/components/secure_space_message/secure_space_message.tsx
View file

@ -6,11 +6,16 @@
import { EuiHorizontalRule, EuiLink, EuiText } from '@elastic/eui'; import { EuiHorizontalRule, EuiLink, EuiText } from '@elastic/eui';
import { FormattedMessage } from '@kbn/i18n/react'; import { FormattedMessage } from '@kbn/i18n/react';
import { i18n } from '@kbn/i18n';
import React, { Fragment } from 'react'; import React, { Fragment } from 'react';
import { capabilities } from 'ui/capabilities'; import { capabilities } from 'ui/capabilities';
export const SecureSpaceMessage = ({}) => { export const SecureSpaceMessage = ({}) => {
if (capabilities.get().spaces.manage) { if (capabilities.get().spaces.manage) {
const rolesLinkTextAriaLabel = i18n.translate(
'xpack.spaces.management.secureSpaceMessage.rolesLinkTextAriaLabel',
{ defaultMessage: 'Roles management page' }
);
return ( return (
<Fragment> <Fragment>
<EuiHorizontalRule /> <EuiHorizontalRule />
@ -21,7 +26,7 @@ export const SecureSpaceMessage = ({}) => {
defaultMessage="Want to assign a role to a space? Go to {rolesLink}." defaultMessage="Want to assign a role to a space? Go to {rolesLink}."
values={{ values={{
rolesLink: ( rolesLink: (
<EuiLink href="#/management/security/roles"> <EuiLink href="#/management/security/roles" aria-label={rolesLinkTextAriaLabel}>
<FormattedMessage <FormattedMessage
id="xpack.spaces.management.secureSpaceMessage.rolesLinkText" id="xpack.spaces.management.secureSpaceMessage.rolesLinkText"
defaultMessage="Roles" defaultMessage="Roles"