github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 17:59:23 -04:00
Code Issues Projects Releases Packages Wiki Activity

Fixes Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/alert_create_flyout·ts - Actions and Triggers app create alert should show save confirmation before creating alert with no actions (#85623) (#86169)

Browse source 
* Unskipping test

* Using simpler alert type during test

* Fixing test

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This commit is contained in:
ymao1 2020-12-16 17:02:06 -05:00 • committed by GitHub
parent 527415577e
commit 9735f90991
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

7
x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/alert_create_flyout.ts
View file

@ -61,8 +61,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
await testSubjects.click('test.always-firing-SelectOption'); await testSubjects.click('test.always-firing-SelectOption');
} }
// FLAKY: https://github.com/elastic/kibana/issues/85105 describe('create alert', function () {
describe.skip('create alert', function () {
before(async () => { before(async () => {
await pageObjects.common.navigateToApp('triggersActions'); await pageObjects.common.navigateToApp('triggersActions');
await testSubjects.click('alertsTab'); await testSubjects.click('alertsTab');
@ -179,7 +178,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
it('should show save confirmation before creating alert with no actions', async () => { it('should show save confirmation before creating alert with no actions', async () => {
const alertName = generateUniqueKey(); const alertName = generateUniqueKey();
await defineAlert(alertName); await defineAlwaysFiringAlert(alertName);
await testSubjects.click('saveAlertButton'); await testSubjects.click('saveAlertButton');
await testSubjects.existOrFail('confirmAlertSaveModal'); await testSubjects.existOrFail('confirmAlertSaveModal');
@ -200,7 +199,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
{ {
name: alertName, name: alertName,
tagsText: '', tagsText: '',
alertType: 'Index threshold', alertType: 'Always Firing',
interval: '1m', interval: '1m',
}, },
]); ]);