github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 17:59:23 -04:00
Code Issues Projects Releases Packages Wiki Activity

Add description for vis types (#26243) (#26280)

Browse source
This commit is contained in:
Tim Roes 2018-11-27 19:44:05 +01:00 • committed by GitHub
parent 3898f5b3ba
commit 97fd4481c8
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 22 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/core_plugins/kibana/public/visualize/wizard/__snapshots__/new_vis_modal.test.tsx.snap
View file

@ -504,6 +504,7 @@ exports[`NewVisModal should render as expected 1`] = `
role="menu"
>
<EuiKeyPadMenuItemButton
aria-describedby="visTypeDescription-vis"
className="visNewVisDialog__type"
data-test-subj="visType-vis"
data-vis-stage="production"
@ -523,6 +524,7 @@ exports[`NewVisModal should render as expected 1`] = `
onMouseLeave={[Function]}
>
<button
aria-describedby="visTypeDescription-vis"
className="euiKeyPadMenuItem visNewVisDialog__type"
data-test-subj="visType-vis"
data-vis-stage="production"
@ -598,6 +600,7 @@ exports[`NewVisModal should render as expected 1`] = `
</button>
</EuiKeyPadMenuItemButton>
<EuiKeyPadMenuItemButton
aria-describedby="visTypeDescription-visWithSearch"
className="visNewVisDialog__type"
data-test-subj="visType-visWithSearch"
data-vis-stage="production"
@ -617,6 +620,7 @@ exports[`NewVisModal should render as expected 1`] = `
onMouseLeave={[Function]}
>
<button
aria-describedby="visTypeDescription-visWithSearch"
className="euiKeyPadMenuItem visNewVisDialog__type"
data-test-subj="visType-visWithSearch"
data-vis-stage="production"

1
src/core_plugins/kibana/public/visualize/wizard/type_selection/type_selection.tsx
View file

@ -180,6 +180,7 @@ class TypeSelection extends React.Component<TypeSelectionProps, TypeSelectionSta
data-test-subj={`visType-${visType.name}`}
data-vis-stage={visType.stage}
disabled={isDisabled}
aria-describedby={`visTypeDescription-${visType.name}`}
{...stage}
>
<VisTypeIcon visType={visType} />

32
src/core_plugins/kibana/public/visualize/wizard/type_selection/vis_help_text.tsx
View file

@ -35,21 +35,23 @@ export const VisHelpText = ({ visType }: VisHelpTextProps) => {
<h2>{visType.title}</h2>
</EuiTitle>
<EuiSpacer size="s" />
{visType.stage === 'experimental' && (
<React.Fragment>
<EuiText>
<em>
<FormattedMessage
id="kbn.visualize.newVisWizard.experimentalDescription"
defaultMessage="This visualization is experimental. The design and implementation
are less mature than stable visualizations and might be subject to change."
/>
</em>
</EuiText>
<EuiSpacer size="s" />
</React.Fragment>
)}
<EuiText>{visType.description}</EuiText>
<div id={`visTypeDescription-${visType.name}`}>
{visType.stage === 'experimental' && (
<React.Fragment>
<EuiText>
<em>
<FormattedMessage
id="kbn.visualize.newVisWizard.experimentalDescription"
defaultMessage="This visualization is experimental. The design and implementation
are less mature than stable visualizations and might be subject to change."
/>
</em>
</EuiText>
<EuiSpacer size="s" />
</React.Fragment>
)}
<EuiText>{visType.description}</EuiText>
</div>
</React.Fragment>
);
};