github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-23 17:28:26 -04:00
Code Issues Projects Releases Packages Wiki Activity

[Maps] Use PageObject service methods to fix flaky test (#155161)

Browse source 
Fixes #154913 

## Summary

Changes functional test to use the maps PageObject methods for entering
and exiting fullscreen. These methods provide better retry handling.
This commit is contained in:
Nick Peihl 2023-04-18 16:22:49 -04:00 • committed by GitHub
parent 613619bee2
commit 98843eeef4
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

7
x-pack/test/accessibility/apps/maps.ts
View file

@ -14,8 +14,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
const inspector = getService('inspector');
const PageObjects = getPageObjects(['common', 'settings', 'header', 'home', 'maps']);
// Failing: See https://github.com/elastic/kibana/issues/154913
describe.skip('Maps app Accessibility', () => {
describe('Maps app Accessibility', () => {
before(async () => {
await PageObjects.common.navigateToUrl('home', '/tutorial_directory/sampleData', {
useActualUrl: true,
@ -79,12 +78,12 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
});
it('full screen button should exist', async () => {
await testSubjects.click('mapsFullScreenMode');
await PageObjects.maps.existFullScreen();
await a11y.testAppSnapshot();
});
it('displays exit full screen logo button', async () => {
await testSubjects.click('exitFullScreenModeButton');
await PageObjects.maps.enterFullScreen();
await a11y.testAppSnapshot();
});