github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 01:38:56 -04:00
Code Issues Projects Releases Packages Wiki Activity

[Search] Fix index error incorrectly showing up (#189283)

Browse source 
## Summary

This fixes a bug where the index error would show up for third-party
models because the logic for determining local models was incorrect.
This commit is contained in:
Sander Philipse 2024-07-26 16:34:35 +02:00 • committed by GitHub
parent 27bddf284f
commit 98a7da9a83
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
x-pack/plugins/enterprise_search/public/applications/enterprise_search_content/components/search_index/index_error.tsx
View file

@ -66,7 +66,7 @@ function hasProperties(field: MappingProperty): field is MappingPropertyBase {
}
function isLocalModel(model: InferenceServiceSettings): model is LocalInferenceServiceSettings {
return Boolean((model as LocalInferenceServiceSettings).service_settings.model_id);
return ['elser', 'elasticsearch'].includes((model as LocalInferenceServiceSettings).service);
}
export const IndexError: React.FC<IndexErrorProps> = ({ indexName }) => {
@ -124,7 +124,7 @@ export const IndexError: React.FC<IndexErrorProps> = ({ indexName }) => {
if (!modelStats || modelStats.deployment_stats?.state !== 'started') {
return {
error: i18n.translate(
'xpack.enterpriseSearch.indexOverview.indexErrors.missingModelError',
'xpack.enterpriseSearch.indexOverview.indexErrors.modelNotDeployedError',
{
defaultMessage:
'Model {modelId} for inference endpoint {inferenceId} in field {fieldName} has not been started',