mirror of
https://github.com/elastic/kibana.git
synced 2025-06-27 18:51:07 -04:00
[Search Home Page V1] Resolve the flaky FTR tests (#225328)
## Summary Previously, we skipped some FTR tests related to redirection from the Search home page for Admin and Developer roles. In this PR, we’ve resolved the flakiness by moving the test file earlier in the test loading sequence. ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) ### Identify risks Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [ ] [See some risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) - [ ] ...
This commit is contained in:
parent
96780d7e1d
commit
998a1a2a8e
2 changed files with 5 additions and 3 deletions
|
@ -13,6 +13,7 @@ export default function ({ loadTestFile }: FtrProviderContext) {
|
|||
|
||||
loadTestFile(require.resolve('./navigation'));
|
||||
loadTestFile(require.resolve('./elasticsearch_start.ts'));
|
||||
loadTestFile(require.resolve('./search_homepage'));
|
||||
loadTestFile(require.resolve('./search_index_detail.ts'));
|
||||
loadTestFile(require.resolve('./getting_started'));
|
||||
loadTestFile(require.resolve('./index_management'));
|
||||
|
@ -29,6 +30,5 @@ export default function ({ loadTestFile }: FtrProviderContext) {
|
|||
loadTestFile(require.resolve('./ml'));
|
||||
loadTestFile(require.resolve('./custom_role_access'));
|
||||
loadTestFile(require.resolve('./inference_management'));
|
||||
loadTestFile(require.resolve('./search_homepage'));
|
||||
});
|
||||
}
|
||||
|
|
|
@ -29,7 +29,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
|
|||
const testSubjects = getService('testSubjects');
|
||||
|
||||
describe('Search Homepage', function () {
|
||||
describe.skip('as admin', function () {
|
||||
describe('as admin', function () {
|
||||
before(async () => {
|
||||
await pageObjects.svlCommonPage.loginAsAdmin();
|
||||
});
|
||||
|
@ -39,6 +39,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
|
|||
});
|
||||
|
||||
it('goes to the start page if there exists no index', async () => {
|
||||
await pageObjects.common.navigateToApp('searchHomepage');
|
||||
await pageObjects.svlSearchHomePage.expectToBeOnStartpage();
|
||||
});
|
||||
|
||||
|
@ -49,7 +50,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
|
|||
});
|
||||
});
|
||||
|
||||
describe.skip('as developer', function () {
|
||||
describe('as developer', function () {
|
||||
before(async () => {
|
||||
await pageObjects.svlCommonPage.loginAsDeveloper();
|
||||
});
|
||||
|
@ -59,6 +60,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
|
|||
});
|
||||
|
||||
it('goes to the start page if there exists no index', async () => {
|
||||
await pageObjects.common.navigateToApp('searchHomepage');
|
||||
await pageObjects.svlSearchHomePage.expectToBeOnStartpage();
|
||||
});
|
||||
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue