github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-23 09:19:04 -04:00
Code Issues Projects Releases Packages Wiki Activity

Don't wrap advanced settings callouts in p tags (#143132)

Browse source 
The `<p>` tags around the formatted messages cause the icon to display on a separate line from the text.

This removes that tag so the icon shows inline and it takes up less space.
This commit is contained in:
Nathan L Smith 2022-10-12 09:37:02 -05:00 • committed by GitHub
parent 8acf3feda3
commit 9a24588eff
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 35 additions and 41 deletions
Download patch file Download diff file Expand all files Collapse all files

30
src/plugins/telemetry_management_section/public/components/__snapshots__/telemetry_management_section.test.tsx.snap generated
View file

@ -24,23 +24,21 @@ exports[`TelemetryManagementSectionComponent renders as expected 1`] = `
color="primary"
iconType="spacesApp"
title={
<p>
<FormattedMessage
defaultMessage="Changes to this setting apply to {allOfKibanaText} and are saved automatically."
id="telemetry.callout.appliesSettingTitle"
values={
Object {
"allOfKibanaText": <strong>
<FormattedMessage
defaultMessage="all of Kibana"
id="telemetry.callout.appliesSettingTitle.allOfKibanaText"
values={Object {}}
/>
</strong>,
}
<FormattedMessage
defaultMessage="Changes to this setting apply to {allOfKibanaText} and are saved automatically."
id="telemetry.callout.appliesSettingTitle"
values={
Object {
"allOfKibanaText": <strong>
<FormattedMessage
defaultMessage="all of Kibana"
id="telemetry.callout.appliesSettingTitle.allOfKibanaText"
values={Object {}}
/>
</strong>,
}
/>
</p>
}
/>
}
/>
<EuiSpacer

30
src/plugins/telemetry_management_section/public/components/telemetry_management_section.tsx
View file

@ -151,22 +151,20 @@ export class TelemetryManagementSection extends Component<Props, State> {
color="primary"
iconType="spacesApp"
title={
<p>
<FormattedMessage
id="telemetry.callout.appliesSettingTitle"
defaultMessage="Changes to this setting apply to {allOfKibanaText} and are saved automatically."
values={{
allOfKibanaText: (
<strong>
<FormattedMessage
id="telemetry.callout.appliesSettingTitle.allOfKibanaText"
defaultMessage="all of Kibana"
/>
</strong>
),
}}
/>
</p>
<FormattedMessage
id="telemetry.callout.appliesSettingTitle"
defaultMessage="Changes to this setting apply to {allOfKibanaText} and are saved automatically."
values={{
allOfKibanaText: (
<strong>
<FormattedMessage
id="telemetry.callout.appliesSettingTitle.allOfKibanaText"
defaultMessage="all of Kibana"
/>
</strong>
),
}}
/>
}
/>
);

16
x-pack/plugins/spaces/public/advanced_settings/components/advanced_settings_subtitle/advanced_settings_subtitle.tsx
View file

@ -32,15 +32,13 @@ export const AdvancedSettingsSubtitle = (props: Props) => {
color="primary"
iconType="spacesApp"
title={
<p>
<FormattedMessage
id="xpack.spaces.management.advancedSettingsSubtitle.applyingSettingsOnPageToSpaceDescription"
defaultMessage="The settings on this page apply to the {spaceName} space, unless otherwise specified."
values={{
spaceName: <strong>{activeSpace.name}</strong>,
}}
/>
</p>
<FormattedMessage
id="xpack.spaces.management.advancedSettingsSubtitle.applyingSettingsOnPageToSpaceDescription"
defaultMessage="The settings on this page apply to the {spaceName} space, unless otherwise specified."
values={{
spaceName: <strong>{activeSpace.name}</strong>,
}}
/>
}
/>
</Fragment>