github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 17:59:23 -04:00
Code Issues Projects Releases Packages Wiki Activity

fixing multiple metrics (#62929) (#62961)

Browse source
This commit is contained in:
Peter Pisljar 2020-04-09 11:01:06 +02:00 • committed by GitHub
parent 9645f6f4ab
commit 9aa599c18d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 5 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
src/legacy/core_plugins/vis_type_vislib/public/components/options/metrics_axes/__snapshots__/index.test.tsx.snap generated
View file

@ -54,6 +54,7 @@ exports[`MetricsAxisOptions component should init with the default set of props
}
vis={
Object {
"serialize": [MockFunction],
"setState": [MockFunction],
"type": Object {
"schemas": Object {
@ -126,6 +127,7 @@ exports[`MetricsAxisOptions component should init with the default set of props
}
vis={
Object {
"serialize": [MockFunction],
"setState": [MockFunction],
"type": Object {
"schemas": Object {
@ -169,6 +171,7 @@ exports[`MetricsAxisOptions component should init with the default set of props
setCategoryAxis={[Function]}
vis={
Object {
"serialize": [MockFunction],
"setState": [MockFunction],
"type": Object {
"schemas": Object {

1
src/legacy/core_plugins/vis_type_vislib/public/components/options/metrics_axes/index.test.tsx
View file

@ -95,6 +95,7 @@ describe('MetricsAxisOptions component', () => {
schemas: { metrics: [{ name: 'metric' }] },
},
setState: jest.fn(),
serialize: jest.fn(),
},
stateParams: {
valueAxes: [axis],

2
src/legacy/core_plugins/vis_type_vislib/public/components/options/metrics_axes/index.tsx
View file

@ -299,7 +299,7 @@ function MetricsAxisOptions(props: ValidationVisOptionsProps<BasicVislibParams>)
}, [stateParams.seriesParams]);
useEffect(() => {
vis.setState({ type: visType } as any);
vis.setState({ ...vis.serialize(), type: visType });
}, [vis, visType]);
return isTabSelected ? (