[6.8] Fix disappearing screenshots in CI (#46382) (#46667)

# Conflicts:
#	test/functional/services/failure_debugging.ts
#	test/functional/services/screenshots.ts
#	test/functional/services/snapshots.ts
This commit is contained in:
Spencer 2019-09-26 07:32:41 -07:00 committed by GitHub
parent 6df1cf343c
commit 9af8b55de3
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 2 deletions

View file

@ -33,7 +33,9 @@ export async function FailureDebuggingProvider({ getService }) {
const log = getService('log');
const browser = getService('browser');
await del(config.get('failureDebugging.htmlDirectory'));
if (process.env.CI !== 'true') {
await del(config.get('failureDebugging.htmlDirectory'));
}
async function logCurrentUrl() {
const currentUrl = await browser.getCurrentUrl();

View file

@ -35,7 +35,10 @@ export async function ScreenshotsProvider({ getService }) {
const SESSION_DIRECTORY = resolve(config.get('screenshots.directory'), 'session');
const FAILURE_DIRECTORY = resolve(config.get('screenshots.directory'), 'failure');
const BASELINE_DIRECTORY = resolve(config.get('screenshots.directory'), 'baseline');
await del([SESSION_DIRECTORY, FAILURE_DIRECTORY]);
if (process.env.CI !== 'true') {
await del([SESSION_DIRECTORY, FAILURE_DIRECTORY]);
}
class Screenshots {