github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 01:38:56 -04:00
Code Issues Projects Releases Packages Wiki Activity

[plugin-helpers] fix order of arguments passed to commander actions (#17663)

Browse source
This commit is contained in:
Spencer 2018-04-11 12:20:18 -07:00 • committed by GitHub
parent 6c1bf403e2
commit 9bbf8ce12e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

3
packages/kbn-plugin-helpers/lib/__snapshots__/commander_action.test.js.snap
View file

@ -30,11 +30,12 @@ Array [
"taskName",
Object {
"args": Array [
"f",
"a",
"b",
"c",
"d",
"e",
"f",
],
},
],

6
packages/kbn-plugin-helpers/lib/commander_action.js
View file

@ -1,9 +1,11 @@
const run = require('./run');
module.exports = function createCommanderAction(taskName, getOptions = () => {}) {
return async (command, ...args) => {
return async (...args) => {
try {
await run(taskName, getOptions(...args));
// command is the last arg passed by commander, but we move it to the front of the list
const command = args.pop();
await run(taskName, getOptions(command, ...args));
} catch (error) {
process.stderr.write(`Task "${taskName}" failed:\n\n${error.stack || error.message}\n`);
process.exit(1);