github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-23 01:13:23 -04:00
Code Issues Projects Releases Packages Wiki Activity

[Cases] Fix flakiness in the description tests (#170433)

Browse source 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This commit is contained in:
Christos Nasikas 2023-11-03 11:03:45 +02:00 • committed by GitHub
parent c2f6fc4336
commit 9c2652778f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 20 additions and 21 deletions
Download patch file Download diff file Expand all files Collapse all files

41
x-pack/plugins/cases/public/components/description/index.test.tsx
View file

@ -56,9 +56,7 @@ describe('Description', () => {
userEvent.click(res.getByTestId('description-collapse-icon'));
await waitFor(() => {
expect(screen.getByText('Security banana Issue')).toBeInTheDocument();
});
expect(await screen.findByText('Security banana Issue')).toBeInTheDocument();
});
it('shows textarea on edit click', async () => {
@ -68,9 +66,7 @@ describe('Description', () => {
userEvent.click(res.getByTestId('description-edit-icon'));
await waitFor(() => {
expect(screen.getByTestId('euiMarkdownEditorTextArea')).toBeInTheDocument();
});
expect(await screen.findByTestId('euiMarkdownEditorTextArea')).toBeInTheDocument();
});
it('edits the description correctly when saved', async () => {
@ -82,12 +78,15 @@ describe('Description', () => {
userEvent.click(res.getByTestId('description-edit-icon'));
userEvent.clear(screen.getByTestId('euiMarkdownEditorTextArea'));
userEvent.type(screen.getByTestId('euiMarkdownEditorTextArea'), editedDescription);
userEvent.paste(screen.getByTestId('euiMarkdownEditorTextArea'), editedDescription);
userEvent.click(screen.getByTestId('editable-save-markdown'));
await waitFor(() => {
expect(onUpdateField).toHaveBeenCalledWith({ key: 'description', value: editedDescription });
expect(onUpdateField).toHaveBeenCalledWith({
key: 'description',
value: editedDescription,
});
});
});
@ -100,20 +99,21 @@ describe('Description', () => {
userEvent.click(res.getByTestId('description-edit-icon'));
userEvent.clear(screen.getByTestId('euiMarkdownEditorTextArea'));
userEvent.type(screen.getByTestId('euiMarkdownEditorTextArea'), editedDescription);
userEvent.paste(screen.getByTestId('euiMarkdownEditorTextArea'), editedDescription);
expect(screen.getByText(editedDescription)).toBeInTheDocument();
userEvent.click(screen.getByTestId('editable-cancel-markdown'));
await waitFor(() => {
expect(onUpdateField).not.toHaveBeenCalled();
expect(screen.getByText('Security banana Issue')).toBeInTheDocument();
});
expect(screen.getByText('Security banana Issue')).toBeInTheDocument();
});
it('shows an error when description is too long', async () => {
const longDescription = Array(MAX_DESCRIPTION_LENGTH / 2 + 1)
.fill('a')
.toString();
const longDescription = 'a'.repeat(MAX_DESCRIPTION_LENGTH + 1);
const res = appMockRender.render(
<Description {...defaultProps} onUpdateField={onUpdateField} />
@ -124,14 +124,13 @@ describe('Description', () => {
userEvent.clear(screen.getByTestId('euiMarkdownEditorTextArea'));
userEvent.paste(screen.getByTestId('euiMarkdownEditorTextArea'), longDescription);
await waitFor(() => {
expect(
screen.getByText(
'The length of the description is too long. The maximum length is 30000 characters.'
)
).toBeInTheDocument();
expect(screen.getByTestId('editable-save-markdown')).toHaveAttribute('disabled');
});
expect(
await screen.findByText(
'The length of the description is too long. The maximum length is 30000 characters.'
)
).toBeInTheDocument();
expect(await screen.findByTestId('editable-save-markdown')).toHaveAttribute('disabled');
});
it('should hide the edit button when the user does not have update permissions', () => {