github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 09:48:58 -04:00
Code Issues Projects Releases Packages Wiki Activity

Remove transaction breakdown metrics (#115385)

Browse source
This commit is contained in:
Felix Barnsteiner 2021-11-19 13:44:10 +01:00 • committed by GitHub
parent b2e30c8e1a
commit 9df09ae6a6
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
7 changed files with 16 additions and 101 deletions
Download patch file Download diff file Expand all files Collapse all files

6
x-pack/plugins/apm/common/__snapshots__/elasticsearch_fieldnames.test.ts.snap generated
View file

@ -209,8 +209,6 @@ exports[`Error TBT_FIELD 1`] = `undefined`;
exports[`Error TRACE_ID 1`] = `"trace id"`;
exports[`Error TRANSACTION_BREAKDOWN_COUNT 1`] = `undefined`;
exports[`Error TRANSACTION_DOM_INTERACTIVE 1`] = `undefined`;
exports[`Error TRANSACTION_DURATION 1`] = `undefined`;
@ -448,8 +446,6 @@ exports[`Span TBT_FIELD 1`] = `undefined`;
exports[`Span TRACE_ID 1`] = `"trace id"`;
exports[`Span TRANSACTION_BREAKDOWN_COUNT 1`] = `undefined`;
exports[`Span TRANSACTION_DOM_INTERACTIVE 1`] = `undefined`;
exports[`Span TRANSACTION_DURATION 1`] = `undefined`;
@ -701,8 +697,6 @@ exports[`Transaction TBT_FIELD 1`] = `undefined`;
exports[`Transaction TRACE_ID 1`] = `"trace id"`;
exports[`Transaction TRANSACTION_BREAKDOWN_COUNT 1`] = `undefined`;
exports[`Transaction TRANSACTION_DOM_INTERACTIVE 1`] = `undefined`;
exports[`Transaction TRANSACTION_DURATION 1`] = `1337`;

1
x-pack/plugins/apm/common/elasticsearch_fieldnames.ts
View file

@ -51,7 +51,6 @@ export const TRANSACTION_RESULT = 'transaction.result';
export const TRANSACTION_NAME = 'transaction.name';
export const TRANSACTION_ID = 'transaction.id';
export const TRANSACTION_SAMPLED = 'transaction.sampled';
export const TRANSACTION_BREAKDOWN_COUNT = 'transaction.breakdown.count';
export const TRANSACTION_PAGE_URL = 'transaction.page.url';
// for transaction metrics
export const TRANSACTION_ROOT = 'transaction.root';

22
x-pack/plugins/apm/dev_docs/apm_queries.md
View file

@ -315,28 +315,6 @@ GET apm-*-metric-*,metrics-apm*/_search?terminate_after=1000
The above example is overly simplified. In reality [we do a bit more](https://github.com/elastic/kibana/blob/fe9b5332e157fd456f81aecfd4ffa78d9e511a66/x-pack/plugins/apm/server/lib/metrics/by_agent/shared/memory/index.ts#L51-L71) to properly calculate memory usage inside containers. Please note that an [Exists Query](https://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl-exists-query.html) is used in the filter context in the query to ensure that the memory fields exist.
# Transaction breakdown metrics
A pre-aggregations of transaction documents where `transaction.breakdown.count` is the number of original transactions.
Noteworthy fields: `transaction.name`, `transaction.type`
#### Sample document
```json
{
"@timestamp": "2021-09-27T21:59:59.828Z",
"processor.event": "metric",
"metricset.name": "transaction_breakdown",
"transaction.breakdown.count": 12,
"transaction.name": "GET /api/products",
"transaction.type": "request"
}
}
```
# Span breakdown metrics
A pre-aggregations of span documents where `span.self_time.count` is the number of original spans. Measures the "self-time" for a span type, and optional subtype, within a transaction group.

19
x-pack/plugins/apm/ftr_e2e/cypress/tasks/es_archiver.ts
View file

@ -5,26 +5,29 @@
* 2.0.
*/
import Path from 'path';
import path from 'path';
import { execSync } from 'child_process';
const ES_ARCHIVE_DIR = './cypress/fixtures/es_archiver';
const ES_ARCHIVE_DIR = path.resolve(
__dirname,
'../../cypress/fixtures/es_archiver'
);
// Otherwise execSync would inject NODE_TLS_REJECT_UNAUTHORIZED=0 and node would abort if used over https
const NODE_TLS_REJECT_UNAUTHORIZED = '1';
export const esArchiverLoad = (folder: string) => {
const path = Path.join(ES_ARCHIVE_DIR, folder);
export const esArchiverLoad = (archiveName: string) => {
const archivePath = path.join(ES_ARCHIVE_DIR, archiveName);
execSync(
`node ../../../../scripts/es_archiver load "${path}" --config ../../../test/functional/config.js`,
`node ../../../../scripts/es_archiver load "${archivePath}" --config ../../../test/functional/config.js`,
{ env: { ...process.env, NODE_TLS_REJECT_UNAUTHORIZED }, stdio: 'inherit' }
);
};
export const esArchiverUnload = (folder: string) => {
const path = Path.join(ES_ARCHIVE_DIR, folder);
export const esArchiverUnload = (archiveName: string) => {
const archivePath = path.join(ES_ARCHIVE_DIR, archiveName);
execSync(
`node ../../../../scripts/es_archiver unload "${path}" --config ../../../test/functional/config.js`,
`node ../../../../scripts/es_archiver unload "${archivePath}" --config ../../../test/functional/config.js`,
{ env: { ...process.env, NODE_TLS_REJECT_UNAUTHORIZED }, stdio: 'inherit' }
);
};

52
x-pack/plugins/apm/server/routes/transactions/__snapshots__/queries.test.ts.snap generated
View file

@ -45,11 +45,6 @@ Object {
"field": "span.self_time.sum.us",
},
},
"total_transaction_breakdown_count": Object {
"sum": Object {
"field": "transaction.breakdown.count",
},
},
"types": Object {
"aggs": Object {
"subtypes": Object {
@ -94,11 +89,6 @@ Object {
"field": "span.self_time.sum.us",
},
},
"total_transaction_breakdown_count": Object {
"sum": Object {
"field": "transaction.breakdown.count",
},
},
"types": Object {
"aggs": Object {
"subtypes": Object {
@ -151,20 +141,8 @@ Object {
},
},
Object {
"bool": Object {
"minimum_should_match": 1,
"should": Array [
Object {
"exists": Object {
"field": "span.self_time.sum.us",
},
},
Object {
"exists": Object {
"field": "transaction.breakdown.count",
},
},
],
"exists": Object {
"field": "span.self_time.sum.us",
},
},
],
@ -191,11 +169,6 @@ Object {
"field": "span.self_time.sum.us",
},
},
"total_transaction_breakdown_count": Object {
"sum": Object {
"field": "transaction.breakdown.count",
},
},
"types": Object {
"aggs": Object {
"subtypes": Object {
@ -240,11 +213,6 @@ Object {
"field": "span.self_time.sum.us",
},
},
"total_transaction_breakdown_count": Object {
"sum": Object {
"field": "transaction.breakdown.count",
},
},
"types": Object {
"aggs": Object {
"subtypes": Object {
@ -297,20 +265,8 @@ Object {
},
},
Object {
"bool": Object {
"minimum_should_match": 1,
"should": Array [
Object {
"exists": Object {
"field": "span.self_time.sum.us",
},
},
Object {
"exists": Object {
"field": "transaction.breakdown.count",
},
},
],
"exists": Object {
"field": "span.self_time.sum.us",
},
},
Object {

16
x-pack/plugins/apm/server/routes/transactions/breakdown/index.ts
View file

@ -15,7 +15,6 @@ import {
SPAN_SELF_TIME_SUM,
TRANSACTION_TYPE,
TRANSACTION_NAME,
TRANSACTION_BREAKDOWN_COUNT,
} from '../../../../common/elasticsearch_fieldnames';
import { Setup } from '../../../lib/helpers/setup_request';
import { rangeQuery, kqlQuery } from '../../../../../observability/server';
@ -51,11 +50,6 @@ export async function getTransactionBreakdown({
field: SPAN_SELF_TIME_SUM,
},
},
total_transaction_breakdown_count: {
sum: {
field: TRANSACTION_BREAKDOWN_COUNT,
},
},
types: {
terms: {
field: SPAN_TYPE,
@ -92,15 +86,7 @@ export async function getTransactionBreakdown({
...rangeQuery(start, end),
...environmentQuery(environment),
...kqlQuery(kuery),
{
bool: {
should: [
{ exists: { field: SPAN_SELF_TIME_SUM } },
{ exists: { field: TRANSACTION_BREAKDOWN_COUNT } },
],
minimum_should_match: 1,
},
},
{ exists: { field: SPAN_SELF_TIME_SUM } },
];
if (transactionName) {

1
x-pack/plugins/observability/public/components/shared/exploratory_view/configurations/constants/elasticsearch_fieldnames.ts
View file

@ -49,7 +49,6 @@ export const TRANSACTION_RESULT = 'transaction.result';
export const TRANSACTION_NAME = 'transaction.name';
export const TRANSACTION_ID = 'transaction.id';
export const TRANSACTION_SAMPLED = 'transaction.sampled';
export const TRANSACTION_BREAKDOWN_COUNT = 'transaction.breakdown.count';
export const TRANSACTION_PAGE_URL = 'transaction.page.url';
// for transaction metrics
export const TRANSACTION_ROOT = 'transaction.root';