[8.17] [product documentation] Fix index names (#202265) (#202307)

# Backport

This will backport the following commits from `main` to `8.17`:
- [[product documentation] Fix index names
(#202265)](https://github.com/elastic/kibana/pull/202265)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Pierre
Gayvallet","email":"pierre.gayvallet@elastic.co"},"sourceCommit":{"committedDate":"2024-11-29T13:33:17Z","message":"[product
documentation] Fix index names (#202265)\n\n## Summary\r\n\r\nFollow-up
of https://github.com/elastic/kibana/pull/194379.\r\n\r\nTurns out, the
prefix for kibana system indices is `.kibana_*`, so our\r\nindices were
not considered as kibana system indices and causing\r\nwarnings when
created, such as\r\n\r\n```\r\nElasticsearch deprecation: 299
Elasticsearch-6db572c986d7e114b8b46f1d6f4169bed06717c5 \"index name
[.kibana-ai-product-doc-kibana] starts with a dot '.', in the next major
version, index names starting with a dot are reserved for hidden indices
and system indices\"\r\nOrigin:kibana\r\n```\r\n\r\nThis PR addresses
it, by changing the product doc index names to follow\r\nour system
index
pattern.","sha":"d5cf0a6be4a4f4436a2aff7636d84558260541b0","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","v9.0.0","backport:version","Team:AI
Infra","v8.17.0","v8.18.0","Feature:AI Product Docs"],"title":"[product
documentation] Fix index
names","number":202265,"url":"https://github.com/elastic/kibana/pull/202265","mergeCommit":{"message":"[product
documentation] Fix index names (#202265)\n\n## Summary\r\n\r\nFollow-up
of https://github.com/elastic/kibana/pull/194379.\r\n\r\nTurns out, the
prefix for kibana system indices is `.kibana_*`, so our\r\nindices were
not considered as kibana system indices and causing\r\nwarnings when
created, such as\r\n\r\n```\r\nElasticsearch deprecation: 299
Elasticsearch-6db572c986d7e114b8b46f1d6f4169bed06717c5 \"index name
[.kibana-ai-product-doc-kibana] starts with a dot '.', in the next major
version, index names starting with a dot are reserved for hidden indices
and system indices\"\r\nOrigin:kibana\r\n```\r\n\r\nThis PR addresses
it, by changing the product doc index names to follow\r\nour system
index
pattern.","sha":"d5cf0a6be4a4f4436a2aff7636d84558260541b0"}},"sourceBranch":"main","suggestedTargetBranches":["8.17","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/202265","number":202265,"mergeCommit":{"message":"[product
documentation] Fix index names (#202265)\n\n## Summary\r\n\r\nFollow-up
of https://github.com/elastic/kibana/pull/194379.\r\n\r\nTurns out, the
prefix for kibana system indices is `.kibana_*`, so our\r\nindices were
not considered as kibana system indices and causing\r\nwarnings when
created, such as\r\n\r\n```\r\nElasticsearch deprecation: 299
Elasticsearch-6db572c986d7e114b8b46f1d6f4169bed06717c5 \"index name
[.kibana-ai-product-doc-kibana] starts with a dot '.', in the next major
version, index names starting with a dot are reserved for hidden indices
and system indices\"\r\nOrigin:kibana\r\n```\r\n\r\nThis PR addresses
it, by changing the product doc index names to follow\r\nour system
index
pattern.","sha":"d5cf0a6be4a4f4436a2aff7636d84558260541b0"}},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Pierre Gayvallet <pierre.gayvallet@elastic.co>

x-pack/packages/ai-infra/product-doc-common/src/indices.ts

@@ -7,9 +7,9 @@
 
 import type { ProductName } from './product';
 
-export const productDocIndexPrefix = '.kibana-ai-product-doc';
-export const productDocIndexPattern = `${productDocIndexPrefix}-*`;
+export const productDocIndexPrefix = '.kibana_ai_product_doc';
+export const productDocIndexPattern = `${productDocIndexPrefix}_*`;
 
 export const getProductDocIndexName = (productName: ProductName): string => {
-  return `${productDocIndexPrefix}-${productName.toLowerCase()}`;
+  return `${productDocIndexPrefix}_${productName.toLowerCase()}`;
 };