github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-23 09:19:04 -04:00
Code Issues Projects Releases Packages Wiki Activity

Median label shows "Median" instead of "50th percentile of" (#58521) (#58612)

Browse source 
* Median label shows "Median" instead of "50th percentile of"

* Update test

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This commit is contained in:
Wylie Conlon 2020-02-26 13:25:16 -05:00 • committed by GitHub
parent f29de7ce1a
commit a0cdf39feb
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 20 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

18
src/legacy/core_plugins/data/public/search/aggs/metrics/median.test.ts
View file

@ -47,7 +47,6 @@ describe('AggTypeMetricMedianProvider class', () => {
schema: 'metric',
params: {
field: 'bytes',
percents: [70],
},
},
],
@ -58,12 +57,21 @@ describe('AggTypeMetricMedianProvider class', () => {
it('requests the percentiles aggregation in the Elasticsearch query DSL', () => {
const dsl: Record<string, any> = aggConfigs.toDsl();
expect(dsl.median.percentiles.percents).toEqual([70]);
expect(dsl.median.percentiles.field).toEqual('bytes');
expect(dsl.median.percentiles.percents).toEqual([50]);
});
it('asks Elasticsearch for array-based values in the aggregation response', () => {
const dsl: Record<string, any> = aggConfigs.toDsl();
it('converts the response', () => {
const agg = aggConfigs.getResponseAggs()[0];
expect(dsl.median.percentiles.keyed).toBeFalsy();
expect(
agg.getValue({
[agg.id]: {
values: {
'50.0': 10,
},
},
})
).toEqual(10);
});
});

14
src/legacy/core_plugins/data/public/search/aggs/metrics/median.ts
View file

@ -43,17 +43,13 @@ export const medianMetricAgg = new MetricAggType({
name: 'field',
type: 'field',
filterFieldTypes: [KBN_FIELD_TYPES.NUMBER, KBN_FIELD_TYPES.DATE],
},
{
name: 'percents',
default: [50],
},
{
write(agg, output) {
output.params.keyed = false;
output.params.field = agg.getParam('field').name;
output.params.percents = [50];
},
},
],
getResponseAggs: percentilesMetricAgg.getResponseAggs,
getValue: percentilesMetricAgg.getValue,
getValue(agg, bucket) {
return bucket[agg.id].values['50.0'];
},
});

2
src/legacy/core_plugins/data/public/search/aggs/metrics/percentiles_get_value.ts
View file

@ -24,7 +24,7 @@ export const getPercentileValue = <TAggConfig extends IResponseAggConfig>(
agg: TAggConfig,
bucket: any
) => {
const { values } = bucket[agg.parentId] && bucket[agg.parentId];
const { values } = bucket[agg.parentId];
const percentile: any = find(values, ({ key }) => key === agg.key);

2
test/functional/apps/visualize/_metric_chart.js
View file

@ -78,7 +78,7 @@ export default function({ getService, getPageObjects }) {
});
it('should show Median', async function() {
const medianBytes = ['5,565.263', '50th percentile of bytes'];
const medianBytes = ['5,565.263', 'Median bytes'];
// For now, only comparing the text label part of the metric
log.debug('Aggregation = Median');
await PageObjects.visEditor.selectAggregation('Median', 'metrics');