[7.4] Fix disappearing screenshots in CI (#46382) (#46663)

This commit is contained in:
Spencer 2019-09-26 07:31:32 -07:00 committed by GitHub
parent 297f4da979
commit a0fe3e1efc
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 9 additions and 3 deletions

View file

@ -41,7 +41,9 @@ export async function FailureDebuggingProvider({ getService }: FtrProviderContex
const log = getService('log');
const browser = getService('browser');
await del(config.get('failureDebugging.htmlDirectory'));
if (process.env.CI !== 'true') {
await del(config.get('failureDebugging.htmlDirectory'));
}
async function logCurrentUrl() {
const currentUrl = await browser.getCurrentUrl();

View file

@ -40,7 +40,8 @@ export async function ScreenshotsProvider({ getService }: FtrProviderContext) {
const SESSION_DIRECTORY = resolve(config.get('screenshots.directory'), 'session');
const FAILURE_DIRECTORY = resolve(config.get('screenshots.directory'), 'failure');
const BASELINE_DIRECTORY = resolve(config.get('screenshots.directory'), 'baseline');
if (!process.env.IS_PIPELINE_JOB) {
if (process.env.CI !== 'true') {
await del([SESSION_DIRECTORY, FAILURE_DIRECTORY]);
}

View file

@ -35,7 +35,10 @@ export async function SnapshotsProvider({ getService }: FtrProviderContext) {
const SESSION_DIRECTORY = resolve(config.get('snapshots.directory'), 'session');
const BASELINE_DIRECTORY = resolve(config.get('snapshots.directory'), 'baseline');
await del([SESSION_DIRECTORY]);
if (process.env.CI !== 'true') {
await del([SESSION_DIRECTORY]);
}
class Snapshots {
/**