github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-23 09:19:04 -04:00
Code Issues Projects Releases Packages Wiki Activity

[SecuritySolution] Fix flaky timeline creation tests (role-based issues) (#173413)

Browse source
This commit is contained in:
Jan Monschke 2024-01-09 22:47:50 +01:00 • committed by GitHub
parent 1d8eb89fb3
commit a100cbb895
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
6 changed files with 59 additions and 62 deletions
Download patch file Download diff file Expand all files Collapse all files

4
x-pack/test/security_solution_cypress/cypress/e2e/investigations/alerts/ransomware_detection.cy.ts
View file

@ -13,7 +13,7 @@ import { ALERTS_URL, TIMELINES_URL } from '../../../urls/navigation';
import { ALERTS_HISTOGRAM_SERIES, ALERT_RULE_NAME, MESSAGE } from '../../../screens/alerts';
import { TIMELINE_QUERY, TIMELINE_VIEW_IN_ANALYZER } from '../../../screens/timeline';
import { selectAlertsHistogram } from '../../../tasks/alerts';
import { createTimeline } from '../../../tasks/timelines';
import { openTimelineUsingToggle } from '../../../tasks/security_main';
import { deleteTimelines } from '../../../tasks/api_calls/common';
describe('Ransomware Detection Alerts', { tags: ['@ess', '@serverless'] }, () => {
@ -53,10 +53,10 @@ describe('Ransomware Detection Alerts', { tags: ['@ess', '@serverless'] }, () =>
deleteTimelines();
login();
visitWithTimeRange(TIMELINES_URL);
createTimeline();
});
it('should show ransomware entries in timelines table', () => {
openTimelineUsingToggle();
cy.get(TIMELINE_QUERY).type('event.code: "ransomware"{enter}');
// Wait for grid to load, it should have an analyzer icon

82
x-pack/test/security_solution_cypress/cypress/e2e/investigations/timelines/creation.cy.ts
View file

@ -45,18 +45,17 @@ import {
addNameToTimelineAndSave,
addNameToTimelineAndSaveAsNew,
} from '../../../tasks/timeline';
import { createTimeline } from '../../../tasks/timelines';
import { waitForTimelinesPanelToBeLoaded } from '../../../tasks/timelines';
import { OVERVIEW_URL, TIMELINE_TEMPLATES_URL, TIMELINES_URL } from '../../../urls/navigation';
// FLAKY: https://github.com/elastic/kibana/issues/173339
describe.skip('Timelines', { tags: ['@ess', '@serverless'] }, (): void => {
describe('Timelines', { tags: ['@ess', '@serverless'] }, (): void => {
beforeEach(() => {
login();
deleteTimelines();
});
it('creates a timeline from a template and should have the same query and open the timeline modal', () => {
it('should create a timeline from a template and should have the same query and open the timeline modal', () => {
login();
createTimelineTemplate(getTimeline());
visit(TIMELINE_TEMPLATES_URL);
selectCustomTemplates();
@ -64,46 +63,35 @@ describe.skip('Timelines', { tags: ['@ess', '@serverless'] }, (): void => {
clickingOnCreateTimelineFormTemplateBtn();
cy.get(TIMELINE_FLYOUT_WRAPPER).should('have.css', 'visibility', 'visible');
cy.get(TIMELINE_QUERY).should('have.text', getTimeline().query);
closeTimeline();
});
describe('Toggle create timeline from "New" btn', () => {
context('Privileges: CRUD', () => {
beforeEach(() => {
login();
visitWithTimeRange(OVERVIEW_URL);
});
it('toggle create timeline ', () => {
openTimelineUsingToggle();
createNewTimeline();
addNameAndDescriptionToTimeline(getTimeline());
cy.get(TIMELINE_PANEL).should('be.visible');
});
});
context('Privileges: READ', () => {
beforeEach(() => {
login(ROLES.t1_analyst);
visitWithTimeRange(OVERVIEW_URL);
});
it('should not be able to create/update timeline ', () => {
openTimelineUsingToggle();
createNewTimeline();
cy.get(TIMELINE_PANEL).should('be.visible');
cy.get(SAVE_TIMELINE_ACTION_BTN).should('be.disabled');
cy.get(SAVE_TIMELINE_ACTION_BTN).first().realHover();
cy.get(SAVE_TIMELINE_TOOLTIP).should('be.visible');
cy.get(SAVE_TIMELINE_TOOLTIP).should(
'have.text',
'You can use Timeline to investigate events, but you do not have the required permissions to save timelines for future use. If you need to save timelines, contact your Kibana administrator.'
);
});
});
it('should be able to create timeline with crud privileges', () => {
login();
visitWithTimeRange(OVERVIEW_URL);
openTimelineUsingToggle();
createNewTimeline();
addNameAndDescriptionToTimeline(getTimeline());
cy.get(TIMELINE_PANEL).should('be.visible');
});
it('creates a timeline by clicking untitled timeline from bottom bar', () => {
it('should not be able to create/update timeline with only read privileges', () => {
login(ROLES.t1_analyst);
visitWithTimeRange(TIMELINES_URL);
waitForTimelinesPanelToBeLoaded();
openTimelineUsingToggle();
createNewTimeline();
cy.get(TIMELINE_PANEL).should('be.visible');
cy.get(SAVE_TIMELINE_ACTION_BTN).should('be.disabled');
cy.get(SAVE_TIMELINE_ACTION_BTN).first().realHover();
cy.get(SAVE_TIMELINE_TOOLTIP).should('be.visible');
cy.get(SAVE_TIMELINE_TOOLTIP).should(
'have.text',
'You can use Timeline to investigate events, but you do not have the required permissions to save timelines for future use. If you need to save timelines, contact your Kibana administrator.'
);
});
it('should create a timeline by clicking untitled timeline from bottom bar', () => {
login();
visitWithTimeRange(OVERVIEW_URL);
openTimelineUsingToggle();
addNameAndDescriptionToTimeline(getTimeline());
@ -126,14 +114,17 @@ describe.skip('Timelines', { tags: ['@ess', '@serverless'] }, (): void => {
.should('have.text', getTimeline().notes);
});
it('shows the different timeline states', () => {
it('should show the different timeline states', () => {
login();
visitWithTimeRange(TIMELINES_URL);
createTimeline();
openTimelineUsingToggle();
// Unsaved
cy.get(TIMELINE_PANEL).should('be.visible');
cy.get(TIMELINE_STATUS).should('be.visible');
cy.get(TIMELINE_STATUS).should('have.text', 'Unsaved');
cy.get(TIMELINE_STATUS)
.invoke('text')
.should('match', /^Unsaved/);
addNameToTimelineAndSave('Test');
@ -155,10 +146,11 @@ describe.skip('Timelines', { tags: ['@ess', '@serverless'] }, (): void => {
});
it('should save timelines as new', () => {
login();
visitWithTimeRange(TIMELINES_URL);
cy.get(ROWS).should('have.length', '0');
createTimeline();
openTimelineUsingToggle();
addNameToTimelineAndSave('First');
// Offsetting the extra save that is happening in the background

4
x-pack/test/security_solution_cypress/cypress/screens/timeline.ts
View file

@ -30,8 +30,6 @@ export const COMBO_BOX_INPUT = '[data-test-subj="comboBoxInput"]';
export const CREATE_NEW_TIMELINE = '[data-test-subj="timeline-new"]';
export const CREATE_NEW_TIMELINE_WITH_BORDER = '[data-test-subj="timeline-new-with-border"]';
export const CREATE_NEW_TIMELINE_TEMPLATE = '[data-test-subj="template-timeline-new"]';
export const DATA_PROVIDERS = '.field-value';
@ -218,6 +216,8 @@ export const TIMELINE_EXIT_FULL_SCREEN_BUTTON = '[data-test-subj="exit-full-scre
export const TIMELINE_FLYOUT_WRAPPER = '[data-test-subj="flyout-pane"]';
export const TIMELINE_WRAPPER = '[data-test-subj="timeline-wrapper"]';
export const TIMELINE_FULL_SCREEN_BUTTON = '[data-test-subj="full-screen-active"]';
export const TIMELINE_PROGRESS_BAR = '[data-test-subj="progress-bar"]';

16
x-pack/test/security_solution_cypress/cypress/tasks/security_main.ts
View file

@ -5,11 +5,23 @@
* 2.0.
*/
import { recurse } from 'cypress-recurse';
import { CLOSE_TIMELINE_BUTTON, TIMELINE_BOTTOM_BAR_TOGGLE_BUTTON } from '../screens/security_main';
import { TIMELINE_EXIT_FULL_SCREEN_BUTTON, TIMELINE_FULL_SCREEN_BUTTON } from '../screens/timeline';
import {
TIMELINE_EXIT_FULL_SCREEN_BUTTON,
TIMELINE_FULL_SCREEN_BUTTON,
TIMELINE_WRAPPER,
} from '../screens/timeline';
export const openTimelineUsingToggle = () => {
cy.get(TIMELINE_BOTTOM_BAR_TOGGLE_BUTTON).click();
recurse(
() => {
cy.get(TIMELINE_BOTTOM_BAR_TOGGLE_BUTTON).click();
return cy.get(TIMELINE_WRAPPER);
},
// Retry if somehow the timeline wrapper is still hidden
($timelineWrapper) => !$timelineWrapper.hasClass('timeline-wrapper--hidden')
);
};
export const closeTimelineUsingCloseButton = () => {

11
x-pack/test/security_solution_cypress/cypress/tasks/timeline.ts
View file

@ -180,9 +180,6 @@ export const addNotesToTimeline = (notes: string) => {
cy.get(`${NOTES_TAB_BUTTON} .euiBadge`).should('have.text', `${notesCount + 1}`);
});
goToQueryTab();
goToNotesTab();
};
export const addEqlToTimeline = (eql: string) => {
@ -303,7 +300,7 @@ export const clickIdToggleField = () => {
};
export const closeTimeline = () => {
cy.get(CLOSE_TIMELINE_BTN).filter(':visible').click();
cy.get(CLOSE_TIMELINE_BTN).click();
cy.get(QUERY_TAB_BUTTON).should('not.be.visible');
};
@ -409,7 +406,7 @@ export const openActiveTimeline = () => {
};
export const pinFirstEvent = (): Cypress.Chainable<JQuery<HTMLElement>> => {
return cy.get(PIN_EVENT).first().click({ force: true });
return cy.get(PIN_EVENT).first().click();
};
export const populateTimeline = () => {
@ -470,11 +467,11 @@ export const refreshTimelinesUntilTimeLinePresent = (
};
export const clickingOnCreateTimelineFormTemplateBtn = () => {
cy.get(TIMELINE_CREATE_TIMELINE_FROM_TEMPLATE_BTN).click({ force: true });
cy.get(TIMELINE_CREATE_TIMELINE_FROM_TEMPLATE_BTN).click();
};
export const clickingOnCreateTemplateFromTimelineBtn = () => {
cy.get(TIMELINE_CREATE_TEMPLATE_FROM_TIMELINE_BTN).click({ force: true });
cy.get(TIMELINE_CREATE_TEMPLATE_FROM_TIMELINE_BTN).click();
};
export const expandEventAction = () => {

4
x-pack/test/security_solution_cypress/cypress/tasks/timelines.ts
View file

@ -21,7 +21,6 @@ import {
} from '../screens/timelines';
import { SELECT_ALL_CHECKBOX } from '../screens/shared';
import {
CREATE_NEW_TIMELINE_WITH_BORDER,
TIMELINE_COLLAPSED_ITEMS_BTN,
TIMELINE_CREATE_TIMELINE_FROM_TEMPLATE_BTN,
} from '../screens/timeline';
@ -68,9 +67,6 @@ export const exportSelectedTimelines = () => {
cy.get(EXPORT_TIMELINE_ACTION).click();
};
export const createTimeline = () =>
cy.get(CREATE_NEW_TIMELINE_WITH_BORDER).should('be.visible').click();
export const createTimelineFromFirstTemplateInList = () => {
cy.get(TIMELINE_COLLAPSED_ITEMS_BTN).first().click();
cy.get(TIMELINE_CREATE_TIMELINE_FROM_TEMPLATE_BTN).click();