mirror of
https://github.com/elastic/kibana.git
synced 2025-06-27 18:51:07 -04:00
## Summary This PR fixes and unskips the Data Discovery tests skipped in #176882. Flaky test runner x50: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5594. Partially resolves #176882. ### Checklist - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: Matthias Wilhelm <matthias.wilhelm@elastic.co>
This commit is contained in:
parent
8abdfb4401
commit
a16be392ef
6 changed files with 13 additions and 12 deletions
|
@ -31,8 +31,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
|
|||
defaultIndex: 'logstash-*',
|
||||
};
|
||||
|
||||
// Failing: See https://github.com/elastic/kibana/issues/176882
|
||||
describe.skip('discover test', function describeIndexTests() {
|
||||
describe('discover test', function describeIndexTests() {
|
||||
before(async function () {
|
||||
log.debug('load kibana index with default index pattern');
|
||||
await kibanaServer.importExport.load('test/functional/fixtures/kbn_archiver/discover');
|
||||
|
|
|
@ -35,8 +35,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
|
|||
hideAnnouncements: true,
|
||||
};
|
||||
|
||||
// Failing: See https://github.com/elastic/kibana/issues/176882
|
||||
describe.skip('discover URL state', () => {
|
||||
describe('discover URL state', () => {
|
||||
before(async function () {
|
||||
log.debug('load kibana index with default index pattern');
|
||||
await kibanaServer.importExport.load('test/functional/fixtures/kbn_archiver/discover');
|
||||
|
|
|
@ -31,8 +31,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
|
|||
defaultIndex: 'logstash-*',
|
||||
};
|
||||
|
||||
// Failing: See https://github.com/elastic/kibana/issues/176882
|
||||
describe.skip('discover test', function describeIndexTests() {
|
||||
describe('discover test', function describeIndexTests() {
|
||||
before(async function () {
|
||||
log.debug('load kibana index with default index pattern');
|
||||
await kibanaServer.importExport.load('test/functional/fixtures/kbn_archiver/discover');
|
||||
|
|
|
@ -32,8 +32,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
|
|||
const log = getService('log');
|
||||
const queryBar = getService('queryBar');
|
||||
|
||||
// Failing: See https://github.com/elastic/kibana/issues/176882
|
||||
describe.skip('discover histogram', function describeIndexTests() {
|
||||
describe('discover histogram', function describeIndexTests() {
|
||||
before(async () => {
|
||||
await esArchiver.loadIfNeeded('test/functional/fixtures/es_archiver/logstash_functional');
|
||||
await esArchiver.load('test/functional/fixtures/es_archiver/long_window_logstash');
|
||||
|
@ -86,7 +85,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
|
|||
|
||||
await PageObjects.discover.brushHistogram();
|
||||
await PageObjects.discover.waitUntilSearchingHasFinished();
|
||||
renderingCountInc = 3; // Multiple renders caused by https://github.com/elastic/kibana/issues/177055
|
||||
renderingCountInc = 4; // Multiple renders caused by https://github.com/elastic/kibana/issues/177055
|
||||
await retry.waitFor('chart rendering complete after being brushed', async () => {
|
||||
const actualCount = await elasticChart.getVisualizationRenderingCount();
|
||||
const expectedCount = prevRenderingCount + renderingCountInc * 2;
|
||||
|
|
|
@ -6,8 +6,14 @@
|
|||
*/
|
||||
import { FtrProviderContext } from '../../../../ftr_provider_context';
|
||||
|
||||
export default ({ loadTestFile }: FtrProviderContext) => {
|
||||
export default ({ getService, loadTestFile }: FtrProviderContext) => {
|
||||
const browser = getService('browser');
|
||||
|
||||
describe('Discover alerting', function () {
|
||||
before(async function () {
|
||||
await browser.setWindowSize(1600, 1200);
|
||||
});
|
||||
|
||||
loadTestFile(require.resolve('./search_source_alert'));
|
||||
});
|
||||
};
|
||||
|
|
|
@ -341,8 +341,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
|
|||
expect(await titleElem.getAttribute('value')).to.equal(dataView);
|
||||
};
|
||||
|
||||
// Failing: See https://github.com/elastic/kibana/issues/176882
|
||||
describe.skip('Search source Alert', () => {
|
||||
describe('Search source Alert', () => {
|
||||
before(async () => {
|
||||
await security.testUser.setRoles(['discover_alert']);
|
||||
await PageObjects.svlCommonPage.loginAsAdmin();
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue