make remove filter work (#58871) (#59217)

This commit is contained in:
Joe Reuter 2020-03-04 08:24:33 +01:00 committed by GitHub
parent ed63c1c24f
commit a181529630
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -279,10 +279,17 @@ export class VegaBaseView {
*/
async removeFilterHandler(query, index) {
const indexId = await this._findIndex(index);
const filter = esFilters.buildQueryFilter(query, indexId);
const filterToRemove = esFilters.buildQueryFilter(query, indexId);
const currentFilters = this._filterManager.getFilters();
const existingFilter = currentFilters.find(filter =>
esFilters.compareFilters(filter, filterToRemove)
);
if (!existingFilter) return;
try {
this._filterManager.removeFilter(filter);
this._filterManager.removeFilter(existingFilter);
} catch (err) {
this.onError(err);
}