github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-23 09:19:04 -04:00
Code Issues Projects Releases Packages Wiki Activity

[ES|QL] Remove client-side parsing error log (#217114)

Browse source 
## Summary

We used to log all parsing errors for diagnostic purposes when since
they were never expected to happen.

With
21845ad7a1
they became much more common, especially while editing queries, because
of ANTLR stack popping exceptions (see
https://github.com/elastic/elasticsearch/issues/119025).

We should stop logging them all to the console... it makes it look like
something is wrong.

Query to test with:
`FROM kibana_sample_data_* 
| WHERE @timestamp != )`
This commit is contained in:
Drew Tate 2025-04-04 08:03:11 -06:00 • committed by GitHub
parent e942404cb9
commit a1db715efe
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 3 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

5
src/platform/packages/shared/kbn-esql-ast/src/parser/parser.ts
View file

@ -149,8 +149,9 @@ export const parse = (text: string | undefined, options: ParseOptions = {}): Par
return { root, ast: commands, errors, tokens: tokens.tokens };
} catch (error) {
// eslint-disable-next-line no-console
console.error(error);
if (error !== 'Empty Stack')
// eslint-disable-next-line no-console
console.error(error);
const root = Builder.expression.query();