github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-06-28 11:05:39 -04:00
Code Issues Projects Releases Packages Wiki Activity

Clean up the developer guide (#71631)

Browse source 
* rename float to discrete

* use same section title level on all source files

* Elasticsearch => {es}

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This commit is contained in:
Stacey Gammon 2020-07-16 10:13:51 -04:00 • committed by GitHub
parent 35e1dd6522
commit a20469f038
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
34 changed files with 338 additions and 336 deletions
Download patch file Download diff file Expand all files Collapse all files

14
docs/developer/contributing/development-pull-request.asciidoc
View file

@ -1,16 +1,16 @@
[[development-pull-request]]
=== Submitting a pull request
== Submitting a pull request
[float]
==== What Goes Into a Pull Request
[discrete]
=== What Goes Into a Pull Request
* Please include an explanation of your changes in your PR description.
* Links to relevant issues, external resources, or related PRs are very important and useful.
* Please update any tests that pertain to your code, and add new tests where appropriate.
* Update or add docs when appropriate. Read more about <<development-documentation>>.
[float]
==== Submitting a Pull Request
[discrete]
=== Submitting a Pull Request
1. Push your local changes to your forked copy of the repository and submit a pull request.
2. Describe what your changes do and mention the number of the issue where discussion has taken place, e.g., “Closes #123″.
@ -22,8 +22,8 @@ Always submit your pull against master unless the bug is only present in an olde
Then sit back and wait. There will probably be discussion about the Pull Request and, if any changes are needed, we'll work with you to get your Pull Request merged into {kib}.
[float]
==== What to expect during the pull request review process
[discrete]
=== What to expect during the pull request review process
Most PRs go through several iterations of feedback and updates. Depending on the scope and complexity of the PR, the process can take weeks. Please
be patient and understand we hold our code base to a high standard.