[ska][x-pack] relocate platform tests [4] (#219691)

## Summary

Part of https://github.com/elastic/kibana-team/issues/1503

This PR is mostly about moving tests from `x-pack/test` to
`x-pack/platform/test`

Before:

```
x-pack/test/
     | - api_integration/apis/management/
     | - api_integration/apis/monitoring/
     | - api_integration/apis/osquery/
     | - automatic_import_api_integration
     | - monitoring_api_integration/
     | - saved_object_api_integration/
```

After: 
```
x-pack/platform/test/
     | - api_integration/apis/management/
     | - api_integration/apis/monitoring/
     | - api_integration/apis/osquery/
     | - automatic_import_api_integration
     | - monitoring_api_integration/
     | - saved_object_api_integration/
```

Additional:

- `x-pack/test/api_integration/apis/osquery/config.ts` was move to
platform stateful manifest to match `osquery` plugin (shared, platform)
- `automatic_import_api_integration` config files were moved to platform
stateful manifest to match `automatic_import` plugin (shared, platform)
- `x-pack/test/common/lib/test_data_loader.ts` is required by SO api
tests and was copied to `x-pack/platform/test/common`

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>

.buildkite/ftr_platform_stateful_configs.yml

@@ -151,10 +151,7 @@ enabled:
   - x-pack/test/api_integration_basic/config.ts
   - x-pack/test/api_integration/apis/cases/config.ts
   - x-pack/test/api_integration/apis/lists/config.ts
-  - x-pack/test/api_integration/apis/management/config.ts
-  - x-pack/test/api_integration/apis/management/index_management/disabled_data_enrichers/config.ts
   - x-pack/test/api_integration/apis/ml/config.ts
-  - x-pack/test/api_integration/apis/monitoring/config.ts
   - x-pack/test/api_integration/apis/search_playground/config.ts
   - x-pack/test/api_integration/apis/security/config.ts
   - x-pack/test/banners_functional/config.ts
@@ -273,7 +270,6 @@ enabled:
   - x-pack/test/functional_search/config.ts
   - x-pack/test/licensing_plugin/config.public.ts
   - x-pack/test/licensing_plugin/config.ts
-  - x-pack/test/monitoring_api_integration/config.ts
   - x-pack/test/plugin_api_integration/config.ts
   - x-pack/test/plugin_functional/config.ts
   - x-pack/test/reporting_api_integration/reporting_and_security.config.ts
@@ -284,10 +280,6 @@ enabled:
   - x-pack/test/rule_registry/security_and_spaces/config_trial.ts
   - x-pack/test/rule_registry/spaces_only/config_basic.ts
   - x-pack/test/rule_registry/spaces_only/config_trial.ts
-  - x-pack/test/saved_object_api_integration/security_and_spaces/config_basic.ts
-  - x-pack/test/saved_object_api_integration/security_and_spaces/config_trial.ts
-  - x-pack/test/saved_object_api_integration/spaces_only/config.ts
-  - x-pack/test/saved_object_api_integration/user_profiles/config.ts
   - x-pack/test/saved_object_tagging/api_integration/security_and_spaces/config.ts
   - x-pack/test/saved_object_tagging/api_integration/tagging_api/config.ts
   - x-pack/test/saved_object_tagging/api_integration/tagging_usage_collection/config.ts
@@ -375,8 +367,12 @@ enabled:
   - x-pack/platform/test/api_integration/apis/file_upload/config.ts
   - x-pack/platform/test/api_integration/apis/kibana/config.ts
   - x-pack/platform/test/api_integration/apis/logstash/config.ts
+  - x-pack/platform/test/api_integration/apis/management/config.ts
+  - x-pack/platform/test/api_integration/apis/management/index_management/disabled_data_enrichers/config.ts
   - x-pack/platform/test/api_integration/apis/maps/config.ts
+  - x-pack/platform/test/api_integration/apis/monitoring/config.ts
   - x-pack/platform/test/api_integration/apis/monitoring_collection/config.ts
+  - x-pack/platform/test/api_integration/apis/osquery/config.ts
   - x-pack/platform/test/api_integration/apis/search/config.ts
   - x-pack/platform/test/api_integration/apis/searchprofiler/config.ts
   - x-pack/platform/test/api_integration/apis/security/config_security_trial.ts
@@ -390,3 +386,10 @@ enabled:
   - x-pack/platform/test/api_integration_basic/apis/aiops/config.ts
   - x-pack/platform/test/api_integration_basic/apis/security/config.ts
   - x-pack/platform/test/api_integration_basic/apis/transform/config.ts
+  - x-pack/platform/test/automatic_import_api_integration/apis/config_basic.ts
+  - x-pack/platform/test/automatic_import_api_integration/apis/config_graphs.ts
+  - x-pack/platform/test/monitoring_api_integration/config.ts
+  - x-pack/platform/test/saved_object_api_integration/security_and_spaces/config_basic.ts
+  - x-pack/platform/test/saved_object_api_integration/security_and_spaces/config_trial.ts
+  - x-pack/platform/test/saved_object_api_integration/spaces_only/config.ts
+  - x-pack/platform/test/saved_object_api_integration/user_profiles/config.ts

.buildkite/ftr_security_stateful_configs.yml

@@ -110,13 +110,10 @@ enabled:
   - x-pack/test/security_solution_endpoint/configs/endpoint.config.ts
   - x-pack/test/security_solution_endpoint/configs/integrations.config.ts
   - x-pack/test/api_integration/apis/cloud_security_posture/config.ts
-  - x-pack/test/api_integration/apis/osquery/config.ts
   - x-pack/test/cloud_security_posture_api/config.ts
   - x-pack/test/cloud_security_posture_functional/config.ts
   - x-pack/test/cloud_security_posture_functional/config.agentless.ts
   - x-pack/test/cloud_security_posture_functional/data_views/config.ts
-  - x-pack/test/automatic_import_api_integration/apis/config_basic.ts
-  - x-pack/test/automatic_import_api_integration/apis/config_graphs.ts
   - x-pack/test/spaces_api_integration/deployment_agnostic/spaces_only/config.ts
   - x-pack/test/spaces_api_integration/deployment_agnostic/security_and_spaces/stateful.config_basic.ts
   - x-pack/test/spaces_api_integration/deployment_agnostic/security_and_spaces/stateful.config_trial.ts

.eslintrc.js

@@ -769,7 +769,7 @@ module.exports = {
         'x-pack/solutions/*/test/**/*config.*ts',
         'x-pack/test/*/{tests,test_suites,apis,apps,deployment_agnostic}/**/*',
         'x-pack/test/*/*config.*ts',
-        'x-pack/test/saved_object_api_integration/*/apis/**/*',
+        'x-pack/platform/test/saved_object_api_integration/*/apis/**/*',
         'x-pack/test/ui_capabilities/*/tests/**/*',
         'x-pack/test/upgrade_assistant_integration/**/*',
         'x-pack/test/performance/**/*.ts',

.github/CODEOWNERS

@@ -945,6 +945,7 @@ x-pack/platform/plugins/shared/task_manager @elastic/response-ops
 x-pack/platform/plugins/shared/timelines @elastic/security-threat-hunting-investigations
 x-pack/platform/plugins/shared/triggers_actions_ui @elastic/response-ops
 x-pack/platform/test
+x-pack/platform/test/saved_object_api_integration/common/plugins/saved_object_test_plugin @elastic/kibana-security
 x-pack/solutions/chat/packages/wc-framework-types-browser @elastic/search-kibana
 x-pack/solutions/chat/packages/wc-framework-types-common @elastic/search-kibana
 x-pack/solutions/chat/packages/wc-framework-types-server @elastic/search-kibana
@@ -1080,7 +1081,6 @@ x-pack/test/plugin_api_integration/plugins/sample_task_plugin @elastic/response-
 x-pack/test/plugin_api_perf/plugins/task_manager_performance @elastic/response-ops
 x-pack/test/plugin_functional/plugins/global_search_test @elastic/kibana-core
 x-pack/test/plugin_functional/plugins/resolver_test @elastic/security-solution
-x-pack/test/saved_object_api_integration/common/plugins/saved_object_test_plugin @elastic/kibana-security
 x-pack/test/security_api_integration/packages/helpers @elastic/kibana-security
 x-pack/test/security_api_integration/plugins/audit_log @elastic/kibana-security
 x-pack/test/security_api_integration/plugins/features_provider @elastic/kibana-security
@@ -1168,7 +1168,7 @@ x-pack/test_serverless/api_integration/test_suites/common/platform_security @ela
 /src/platform/test/functional/apps/management/data_views @elastic/kibana-data-discovery
 /src/platform/test/plugin_functional/test_suites/data_plugin @elastic/kibana-data-discovery
 /x-pack/test/accessibility/apps/group3/search_sessions.ts @elastic/kibana-data-discovery
-/x-pack/test/api_integration/apis/management/rollup/index_patterns_extensions.js @elastic/kibana-data-discovery
+/x-pack/platform/test/api_integration/apis/management/rollup/index_patterns_extensions.js @elastic/kibana-data-discovery
 /x-pack/platform/test/api_integration/apis/search @elastic/kibana-data-discovery
 /x-pack/test/examples/search_examples @elastic/kibana-data-discovery
 /x-pack/test/functional/apps/data_views @elastic/kibana-data-discovery
@@ -1429,12 +1429,12 @@ src/platform/plugins/shared/discover/public/context_awareness/profile_providers/
 /x-pack/test/functional/page_objects/alert_controls.ts @elastic/obs-ux-management-team
 
 # Elastic Stack Monitoring
-/x-pack/test/monitoring_api_integration @elastic/stack-monitoring
+/x-pack/platform/test/monitoring_api_integration @elastic/stack-monitoring
 /x-pack/test/functional/page_objects/monitoring_page.ts @elastic/stack-monitoring
 /x-pack/test/functional/es_archives/monitoring @elastic/stack-monitoring
 /x-pack/test/functional/services/monitoring @elastic/stack-monitoring
 /x-pack/test/functional/apps/monitoring @elastic/stack-monitoring
-/x-pack/test/api_integration/apis/monitoring @elastic/stack-monitoring
+/x-pack/platform/test/api_integration/apis/monitoring @elastic/stack-monitoring
 /x-pack/platform/test/api_integration/apis/monitoring_collection @elastic/stack-monitoring
 /x-pack/test/accessibility/apps/group1/kibana_overview.ts @elastic/stack-monitoring
 /x-pack/test/accessibility/apps/group3/stack_monitoring.ts @elastic/stack-monitoring
@@ -2009,7 +2009,7 @@ x-pack/platform/plugins/private/cloud_integrations/cloud_full_story/server/confi
 /x-pack/test/security_api_integration/ @elastic/kibana-security
 /x-pack/test/security_functional/ @elastic/kibana-security
 /x-pack/test/spaces_api_integration/ @elastic/kibana-security
-/x-pack/test/saved_object_api_integration/ @elastic/kibana-security
+/x-pack/platform/test/saved_object_api_integration/ @elastic/kibana-security
 /x-pack/test_serverless/**/test_suites/common/platform_security/ @elastic/kibana-security
 /x-pack/test_serverless/**/test_suites/search/platform_security/ @elastic/kibana-security
 /x-pack/test_serverless/**/test_suites/observability/platform_security/ @elastic/kibana-security
@@ -2113,7 +2113,7 @@ x-pack/platform/plugins/private/cloud_integrations/cloud_full_story/server/confi
 /x-pack/test_serverless/api_integration/test_suites/search/serverless_search @elastic/search-kibana
 /x-pack/test_serverless/functional/test_suites/search/ @elastic/search-kibana
 /x-pack/test_serverless/functional/test_suites/search/config.ts @elastic/search-kibana  @elastic/appex-qa
-x-pack/test/api_integration/apis/management/index_management/inference_endpoints.ts @elastic/search-kibana
+/x-pack/platform/test/api_integration/apis/management/index_management/inference_endpoints.ts @elastic/search-kibana
 /x-pack/test_serverless/api_integration/test_suites/search @elastic/search-kibana
 /x-pack/test_serverless/functional/page_objects/svl_api_keys.ts @elastic/search-kibana
 /x-pack/test_serverless/functional/page_objects/svl_search_* @elastic/search-kibana
@@ -2194,7 +2194,7 @@ x-pack/test/api_integration/apis/management/index_management/inference_endpoints
 /x-pack/test_serverless/functional/test_suites/common/management/landing_page.ts @elastic/kibana-management
 /x-pack/test_serverless/functional/test_suites/common/dev_tools/ @elastic/kibana-management
 /x-pack/test_serverless/**/test_suites/common/grok_debugger/ @elastic/kibana-management
-/x-pack/test/api_integration/apis/management/ @elastic/kibana-management
+/x-pack/platform/test/api_integration/apis/management/ @elastic/kibana-management
 /x-pack/test/api_integration/deployment_agnostic/apis/management/ @elastic/kibana-management
 /x-pack/test/api_integration/deployment_agnostic/apis/painless_lab/ @elastic/kibana-management
 /x-pack/test/functional/apps/rollup_job/ @elastic/kibana-management
@@ -2564,7 +2564,7 @@ x-pack/test/security_solution_cypress/cypress/tasks/expandable_flyout  @elastic/
 
 ## Security Solution sub teams - security-defend-workflows
 /x-pack/test/defend_workflows_cypress @elastic/security-defend-workflows
-/x-pack/test/api_integration/apis/osquery @elastic/security-defend-workflows
+/x-pack/platform/test/api_integration/apis/osquery @elastic/security-defend-workflows
 /x-pack/solutions/security/plugins/security_solution/public/management/ @elastic/security-defend-workflows
 /x-pack/solutions/security/plugins/security_solution/public/common/lib/endpoint/ @elastic/security-defend-workflows
 /x-pack/solutions/security/plugins/security_solution/public/common/components/endpoint/ @elastic/security-defend-workflows
@@ -2615,7 +2615,7 @@ x-pack/solutions/security/packages/navigation/src/navigation_tree/entity_analyti
 x-pack/test/security_solution_api_integration/test_suites/genai @elastic/security-generative-ai
 
 ## Security Solution sub teams - Automatic Import
-x-pack/test/automatic_import_api_integration @elastic/security-scalability
+x-pack/platform/test/automatic_import_api_integration @elastic/security-scalability
 
 # Security Defend Workflows - OSQuery Ownership
 /x-pack/test/osquery_cypress @elastic/security-defend-workflows

package.json

@@ -799,7 +799,7 @@
     "@kbn/sample-task-plugin-update-by-query": "link:x-pack/test/task_manager_claimer_update_by_query/plugins/sample_task_plugin_mget",
     "@kbn/saved-object-export-transforms-plugin": "link:src/platform/test/plugin_functional/plugins/saved_object_export_transforms",
     "@kbn/saved-object-import-warnings-plugin": "link:src/platform/test/plugin_functional/plugins/saved_object_import_warnings",
-    "@kbn/saved-object-test-plugin": "link:x-pack/test/saved_object_api_integration/common/plugins/saved_object_test_plugin",
+    "@kbn/saved-object-test-plugin": "link:x-pack/platform/test/saved_object_api_integration/common/plugins/saved_object_test_plugin",
     "@kbn/saved-objects-finder-plugin": "link:src/platform/plugins/shared/saved_objects_finder",
     "@kbn/saved-objects-hidden-from-http-apis-type-plugin": "link:src/platform/test/plugin_functional/plugins/saved_objects_hidden_from_http_apis_type",
     "@kbn/saved-objects-hidden-type-plugin": "link:src/platform/test/plugin_functional/plugins/saved_objects_hidden_type",

packages/kbn-check-mappings-update-cli/current_mappings.json

@@ -4022,4 +4022,4 @@
     "dynamic": false,
     "properties": {}
   }
-}
+}

src/platform/packages/private/kbn-repo-packages/modern/package.js

@@ -191,7 +191,10 @@ class Package {
     const dir = this.normalizedRepoRelativeDir;
     const oss = !dir.startsWith('x-pack/');
     const example = dir.startsWith('examples/') || dir.startsWith('x-pack/examples/');
-    const testPlugin = dir.startsWith('src/platform/test/') || dir.startsWith('x-pack/test/');
+    const testPlugin =
+      dir.startsWith('src/platform/test/') ||
+      dir.startsWith('x-pack/platform/test') ||
+      dir.startsWith('x-pack/test/');
 
     return {
       oss,

tsconfig.base.json

@@ -1566,8 +1566,8 @@
       "@kbn/saved-object-export-transforms-plugin/*": ["src/platform/test/plugin_functional/plugins/saved_object_export_transforms/*"],
       "@kbn/saved-object-import-warnings-plugin": ["src/platform/test/plugin_functional/plugins/saved_object_import_warnings"],
       "@kbn/saved-object-import-warnings-plugin/*": ["src/platform/test/plugin_functional/plugins/saved_object_import_warnings/*"],
-      "@kbn/saved-object-test-plugin": ["x-pack/test/saved_object_api_integration/common/plugins/saved_object_test_plugin"],
-      "@kbn/saved-object-test-plugin/*": ["x-pack/test/saved_object_api_integration/common/plugins/saved_object_test_plugin/*"],
+      "@kbn/saved-object-test-plugin": ["x-pack/platform/test/saved_object_api_integration/common/plugins/saved_object_test_plugin"],
+      "@kbn/saved-object-test-plugin/*": ["x-pack/platform/test/saved_object_api_integration/common/plugins/saved_object_test_plugin/*"],
       "@kbn/saved-objects-finder-plugin": ["src/platform/plugins/shared/saved_objects_finder"],
       "@kbn/saved-objects-finder-plugin/*": ["src/platform/plugins/shared/saved_objects_finder/*"],
       "@kbn/saved-objects-hidden-from-http-apis-type-plugin": ["src/platform/test/plugin_functional/plugins/saved_objects_hidden_from_http_apis_type"],

x-pack/platform/plugins/private/monitoring/dev_docs/how_to/work_with_packages.md

@@ -149,7 +149,7 @@ See the [elastic-package-test documentation](https://github.com/elastic/elastic-
 
 The system tests spawn a full setup (`elastic-package stack up` + `elastic-package service up`), install the package and attach a policy to a running agent to collect live data. This real-world setup can be leveraged to continuously validate future versions of the stack when they are released. Right now the service dependencies are running on 8.5.0 and the tests validate that this version is supported. The plan is to have an automated job that opens a PR validating that the tests are still successful with the latest released version.
 
-On the Stack Monitoring side, we have an API integration test suite running against packages; see https://github.com/elastic/kibana/tree/main/x-pack/test/monitoring_api_integration#readme
+On the Stack Monitoring side, we have an API integration test suite running against packages; see https://github.com/elastic/kibana/tree/main/x-pack/platform/test/monitoring_api_integration#readme
 
 ## Troubleshooting
 

x-pack/platform/test/api_integration/apis/management/index.ts

@@ -5,7 +5,9 @@
  * 2.0.
  */
 
-export default function ({ loadTestFile }) {
+import type { FtrProviderContext } from '../../ftr_provider_context';
+
+export default function ({ loadTestFile }: FtrProviderContext) {
   describe('management', () => {
     loadTestFile(require.resolve('./advanced_settings'));
     loadTestFile(require.resolve('./cross_cluster_replication'));