github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 17:59:23 -04:00
Code Issues Projects Releases Packages Wiki Activity

Reenable Rollup Jobs API test that was failing due to interval change in ES. (#36310)

Browse source
This commit is contained in:
CJ Cenizal 2019-05-09 10:18:18 -07:00 • committed by GitHub
parent d0180af6e0
commit a3eaa8fb13
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 13 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

8
x-pack/plugins/rollup/public/crud_app/services/jobs.js
View file

@ -86,7 +86,9 @@ export function deserializeJob(job) {
metrics,
groups: {
date_histogram: {
interval: dateHistogramInterval,
interval,
fixed_interval: fixedInterval,
calendar_interval: calendarInterval,
delay: rollupDelay,
time_zone: dateHistogramTimeZone,
field: dateHistogramField,
@ -108,6 +110,10 @@ export function deserializeJob(job) {
const json = job;
// `interval` is deprecated but still supported. All three of the various interval types are
// mutually exclusive.
const dateHistogramInterval = interval || fixedInterval || calendarInterval;
const deserializedJob = {
id,
indexPattern,

9
x-pack/test/api_integration/apis/management/rollup/rollup.js
View file

@ -124,8 +124,7 @@ export default function ({ getService }) {
expect(job.config.rollup_index).to.eql(payload.job.rollup_index);
});
// broken after snapshot update: https://github.com/elastic/kibana/issues/36269
it.skip('should create the underlying rollup index with the correct aggregations', async () => {
it('should create the underlying rollup index with the correct aggregations', async () => {
await createJob(getJobPayload(indexName));
const { body } = await supertest.get(`${API_BASE_PATH}/indices`);
@ -139,7 +138,11 @@ export default function ({ getService }) {
'testCreatedField': {
'agg': 'date_histogram',
'delay': '1d',
'interval': '24h',
// TODO: Note that we created the job with `interval`, but ES has coerced this to
// `fixed_interval` based on the value we provided. Once we update the UI and
// tests to no longer use the deprecated `interval` property, we can remove
// this comment.
'fixed_interval': '24h',
'time_zone': 'UTC'
}
},