github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-23 09:19:04 -04:00
Code Issues Projects Releases Packages Wiki Activity

herp

Browse source
This commit is contained in:
Rashid Khan 2014-09-19 14:47:09 -07:00
parent eff974dd19
commit a5676e14c1
2 changed files with 31 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/kibana/apps/discover/components/field_chooser/field_chooser.js
View file

@ -75,7 +75,7 @@ define(function (require) {
filter.active = filter.getActive();
});
$scope.$watch('fields', function (newFields) {
$scope.$watchCollection('fields', function (newFields) {
// Find the top N most popular fields
$scope.popularFields = _(newFields)

31
test/unit/specs/apps/discover/directives/field_chooser.js
View file

@ -90,6 +90,36 @@ define(function (require) {
done();
});
it('should show the popular fields header if there are popular fields', function (done) {
var section = getSections($elem);
expect(section.popular.hasClass('ng-hide')).to.be(false);
expect(section.popular.find('li:not(.sidebar-list-header)').length).to.be.above(0);
done();
});
it('should not show the popular fields if there are not any', function (done) {
// Re-init
destroy();
init($elem, {
fields: _.filter(
_.map(indexPattern.fields.raw, function (v, i) { return _.merge(v, {display: false, rowCount: i}); }),
{count: 0}
),
toggle: sinon.spy(),
data: require('fixtures/hits'),
filter: sinon.spy(),
indexPattern: indexPattern
});
var section = getSections($elem);
// Remove the popular fields
$scope.$digest();
expect(section.popular.hasClass('ng-hide')).to.be(true);
expect(section.popular.find('li:not(.sidebar-list-header)').length).to.be(0);
done();
});
it('setting field.display should move the field into selected', function (done) {
var section = getSections($elem);
indexPattern.fields.byName.bytes.display = true;
@ -129,7 +159,6 @@ define(function (require) {
indexPattern.popularizeField = sinon.spy();
$scope.details(field);
expect(indexPattern.popularizeField.called).to.be(true);
expect(field.count).to.be(counter + 1);
done();
});