mirror of
https://github.com/elastic/kibana.git
synced 2025-04-24 01:38:56 -04:00
* bump chromedriver to 2.46.0 (#27302) * [services/leadfoot_element_wrapper] update Session.execute call * [services/leadfoot_element_wrapper] fix clearValueWithKeyboard * fix scripted fields tests * fix heatmap functional test
This commit is contained in:
Dmitry Lemeshko
GitHub
parent
5e86ec3003
commit
a683b34b17
6 changed files with 89 additions and 29 deletions
|
|
@ -338,7 +338,7 @@
|
|||
"chance": "1.0.10",
|
||||
"cheerio": "0.22.0",
|
||||
"chokidar": "1.6.0",
|
||||
"chromedriver": "2.42.1",
|
||||
"chromedriver": "2.46.0",
|
||||
"classnames": "2.2.5",
|
||||
"dedent": "^0.7.0",
|
||||
"delete-empty": "^2.0.0",
|
||||
|
|
|
|||
|
|
@ -249,7 +249,8 @@ export function SettingsPageProvider({ getService, getPageObjects }) {
|
|||
|
||||
async increasePopularity() {
|
||||
const field = await testSubjects.find('editorFieldCount');
|
||||
await field.clearValue();
|
||||
await field.click();
|
||||
await field.clearValueWithKeyboard({ charByChar: true });
|
||||
await field.type('1');
|
||||
}
|
||||
|
||||
|
|
@ -420,7 +421,8 @@ export function SettingsPageProvider({ getService, getPageObjects }) {
|
|||
async setScriptedFieldName(name) {
|
||||
log.debug('set scripted field name = ' + name);
|
||||
const field = await testSubjects.find('editorFieldName');
|
||||
await field.clearValue();
|
||||
await field.click();
|
||||
await field.clearValueWithKeyboard({ charByChar: true });
|
||||
await field.type(name);
|
||||
}
|
||||
|
||||
|
|
@ -473,7 +475,14 @@ export function SettingsPageProvider({ getService, getPageObjects }) {
|
|||
const datePatternField = await find.byCssSelector(
|
||||
'input[data-test-subj="dateEditorPattern"]'
|
||||
);
|
||||
await datePatternField.clearValue();
|
||||
// Both clearValue & clearValueWithKeyboard does not work here
|
||||
// Using retry to clear input in 2 attempts
|
||||
await retry.waitFor('clear date', async () => {
|
||||
await datePatternField.click();
|
||||
await datePatternField.clearValueWithKeyboard({ charByChar: true });
|
||||
const value = await datePatternField.getProperty('value');
|
||||
return value.length === 0;
|
||||
});
|
||||
await datePatternField.type(datePattern);
|
||||
}
|
||||
|
||||
|
|
@ -494,7 +503,12 @@ export function SettingsPageProvider({ getService, getPageObjects }) {
|
|||
async setScriptedFieldScript(script) {
|
||||
log.debug('set scripted field script = ' + script);
|
||||
const field = await testSubjects.find('editorFieldScript');
|
||||
await field.clearValue();
|
||||
const currentValue = await field.getAttribute('value');
|
||||
if (script === currentValue) {
|
||||
return;
|
||||
}
|
||||
await field.click();
|
||||
await field.clearValueWithKeyboard({ charByChar: true });
|
||||
await field.type(script);
|
||||
}
|
||||
|
||||
|
|
@ -537,7 +551,9 @@ export function SettingsPageProvider({ getService, getPageObjects }) {
|
|||
await this.openScriptedFieldHelp('testTab');
|
||||
if (additionalField) {
|
||||
await comboBox.set('additionalFieldsSelect', additionalField);
|
||||
await testSubjects.find('scriptedFieldPreview');
|
||||
await testSubjects.click('runScriptButton');
|
||||
await testSubjects.waitForDeleted('.euiLoadingSpinner');
|
||||
}
|
||||
let scriptResults;
|
||||
await retry.try(async () => {
|
||||
|
|
|
|||
|
|
@ -65,13 +65,7 @@ export function VisualBuilderPageProvider({ getService, getPageObjects }) {
|
|||
// Since we use ACE editor and that isn't really storing its value inside
|
||||
// a textarea we must really select all text and remove it, and cannot use
|
||||
// clearValue().
|
||||
if (process.platform === 'darwin') {
|
||||
await browser.pressKeys([Keys.COMMAND, 'a']); // Select all Mac
|
||||
} else {
|
||||
await browser.pressKeys([Keys.CONTROL, 'a']); // Select all for everything else
|
||||
}
|
||||
await browser.pressKeys(Keys.NULL); // Release modifier keys
|
||||
await browser.pressKeys(Keys.BACKSPACE); // Delete all content
|
||||
await input.clearValueWithKeyboard();
|
||||
await input.type(markdown);
|
||||
await PageObjects.visualize.waitForRenderingCount(prevRenderingCount + 1);
|
||||
}
|
||||
|
|
|
|||
|
|
@ -635,11 +635,11 @@ export function VisualizePageProvider({ getService, getPageObjects }) {
|
|||
const table = await testSubjects.find('heatmapCustomRangesTable');
|
||||
const lastRow = await table.findByCssSelector('tr:last-child');
|
||||
const fromCell = await lastRow.findByCssSelector('td:first-child input');
|
||||
fromCell.clearValue();
|
||||
fromCell.type(`${from}`);
|
||||
await fromCell.clearValue();
|
||||
await fromCell.type(`${from}`);
|
||||
const toCell = await lastRow.findByCssSelector('td:nth-child(2) input');
|
||||
toCell.clearValue();
|
||||
toCell.type(`${to}`);
|
||||
await toCell.clearValue();
|
||||
await toCell.type(`${to}`);
|
||||
}
|
||||
|
||||
async clickYAxisOptions(axisId) {
|
||||
|
|
|
|||
|
|
@ -17,6 +17,8 @@
|
|||
* under the License.
|
||||
*/
|
||||
|
||||
import Keys from 'leadfoot/keys';
|
||||
import { delay } from 'bluebird';
|
||||
import { scrollIntoViewIfNecessary } from './scroll_into_view_if_necessary';
|
||||
|
||||
export class LeadfootElementWrapper {
|
||||
|
|
@ -69,7 +71,31 @@ export class LeadfootElementWrapper {
|
|||
* @return {Promise<void>}
|
||||
*/
|
||||
async clearValue() {
|
||||
await this._leadfootElement.clearValue();
|
||||
// https://bugs.chromium.org/p/chromedriver/issues/detail?id=2702
|
||||
// await this._leadfootElement.clearValue();
|
||||
await this._leadfoot.execute(`arguments[0].value=''`, [this._leadfootElement]);
|
||||
}
|
||||
|
||||
/**
|
||||
* Clear the value of this element using Keyboard
|
||||
* @param { charByChar: false } options
|
||||
*/
|
||||
async clearValueWithKeyboard(options = { charByChar: false }) {
|
||||
if (options.charByChar === true) {
|
||||
const value = await this.getProperty('value');
|
||||
for (let i = 1; i <= value.length; i++) {
|
||||
await this._leadfoot.pressKeys(Keys.BACKSPACE);
|
||||
await delay(100);
|
||||
}
|
||||
} else {
|
||||
if (process.platform === 'darwin') {
|
||||
await this._leadfoot.pressKeys([Keys.COMMAND, 'a']); // Select all Mac
|
||||
} else {
|
||||
await this._leadfoot.pressKeys([Keys.CONTROL, 'a']); // Select all for everything else
|
||||
}
|
||||
await this._leadfoot.pressKeys(Keys.NULL); // Release modifier keys
|
||||
await this._leadfoot.pressKeys(Keys.BACKSPACE); // Delete all content
|
||||
}
|
||||
}
|
||||
|
||||
/**
|
||||
|
|
|
|||
48
yarn.lock
48
yarn.lock
|
|
@ -5433,16 +5433,16 @@ chrome-trace-event@^1.0.0:
|
|||
dependencies:
|
||||
tslib "^1.9.0"
|
||||
|
||||
chromedriver@2.42.1:
|
||||
version "2.42.1"
|
||||
resolved "https://registry.yarnpkg.com/chromedriver/-/chromedriver-2.42.1.tgz#566964c1221fbd9fd1ce836734dd92735f1ff8fb"
|
||||
integrity sha512-ciiSoIZH3Pq3UNvNgITb717MP5aldpvte4BO5sLi/FBeahMoo6QZiQ7kDIG1LQY6yZh7N8dqjjiYENq2/J+Xlw==
|
||||
chromedriver@2.46.0:
|
||||
version "2.46.0"
|
||||
resolved "https://registry.yarnpkg.com/chromedriver/-/chromedriver-2.46.0.tgz#3d78e7eb9bb65dd804fe327a6bf76fced12be053"
|
||||
integrity sha512-dLtKIJW3y/PuFrPmcw6Mb8Nh+HwSqgVrK1rWgTARXhHfWvV822X2VRkx2meU/tg2+YQL6/nNgT6n5qWwIDHbwg==
|
||||
dependencies:
|
||||
del "^3.0.0"
|
||||
extract-zip "^1.6.7"
|
||||
kew "^0.7.0"
|
||||
mkdirp "^0.5.1"
|
||||
request "^2.87.0"
|
||||
request "^2.88.0"
|
||||
tcp-port-used "^1.0.1"
|
||||
|
||||
ci-info@^1.0.0:
|
||||
version "1.1.2"
|
||||
|
|
@ -7000,6 +7000,13 @@ debug@3.X, debug@^3.1.0, debug@^3.2.5:
|
|||
dependencies:
|
||||
ms "^2.1.1"
|
||||
|
||||
debug@4.1.0:
|
||||
version "4.1.0"
|
||||
resolved "https://registry.yarnpkg.com/debug/-/debug-4.1.0.tgz#373687bffa678b38b1cd91f861b63850035ddc87"
|
||||
integrity sha512-heNPJUJIqC+xB6ayLAMHaIrmN9HKa7aQO8MGqKpvCA+uJYVcvR6l5kgdrhRuwPFHU7P5/A1w0BjByPHwpfTDKg==
|
||||
dependencies:
|
||||
ms "^2.1.1"
|
||||
|
||||
debug@^4.1.0:
|
||||
version "4.1.1"
|
||||
resolved "https://registry.yarnpkg.com/debug/-/debug-4.1.1.tgz#3b72260255109c6b589cee050f1d516139664791"
|
||||
|
|
@ -7116,7 +7123,7 @@ deep-extend@^0.6.0:
|
|||
resolved "https://registry.yarnpkg.com/deep-extend/-/deep-extend-0.6.0.tgz#c4fa7c95404a17a9c3e8ca7e1537312b736330ac"
|
||||
integrity sha512-LOHxIOaPYdHlJRtCQfDIVZtfw/ufM8+rVj649RIHzcm/vGwQRXFt6OPqIFWsm2XEMrNIEtWR64sY1LEKD2vAOA==
|
||||
|
||||
deep-is@~0.1.3:
|
||||
deep-is@^0.1.3, deep-is@~0.1.3:
|
||||
version "0.1.3"
|
||||
resolved "https://registry.yarnpkg.com/deep-is/-/deep-is-0.1.3.tgz#b369d6fb5dbc13eecf524f91b070feedc357cf34"
|
||||
integrity sha1-s2nW+128E+7PUk+RsHD+7cNXzzQ=
|
||||
|
|
@ -12353,6 +12360,11 @@ is-upper-case@^1.1.0:
|
|||
dependencies:
|
||||
upper-case "^1.1.0"
|
||||
|
||||
is-url@^1.2.2:
|
||||
version "1.2.4"
|
||||
resolved "https://registry.yarnpkg.com/is-url/-/is-url-1.2.4.tgz#04a4df46d28c4cff3d73d01ff06abeb318a1aa52"
|
||||
integrity sha512-ITvGim8FhRiYe4IQ5uHSkj7pVaPDrCTkNd3yq3cV7iZAcJdHTUMPMEHcqSOy9xZ9qFenQCvi+2wjH9a1nXqHww==
|
||||
|
||||
is-utf8@^0.2.0, is-utf8@^0.2.1:
|
||||
version "0.2.1"
|
||||
resolved "https://registry.yarnpkg.com/is-utf8/-/is-utf8-0.2.1.tgz#4b0da1442104d1b336340e80797e865cf39f7d72"
|
||||
|
|
@ -12395,6 +12407,15 @@ is-wsl@^1.1.0:
|
|||
resolved "https://registry.yarnpkg.com/is-wsl/-/is-wsl-1.1.0.tgz#1f16e4aa22b04d1336b66188a66af3c600c3a66d"
|
||||
integrity sha1-HxbkqiKwTRM2tmGIpmrzxgDDpm0=
|
||||
|
||||
is2@2.0.1:
|
||||
version "2.0.1"
|
||||
resolved "https://registry.yarnpkg.com/is2/-/is2-2.0.1.tgz#8ac355644840921ce435d94f05d3a94634d3481a"
|
||||
integrity sha512-+WaJvnaA7aJySz2q/8sLjMb2Mw14KTplHmSwcSpZ/fWJPkUmqw3YTzSWbPJ7OAwRvdYTWF2Wg+yYJ1AdP5Z8CA==
|
||||
dependencies:
|
||||
deep-is "^0.1.3"
|
||||
ip-regex "^2.1.0"
|
||||
is-url "^1.2.2"
|
||||
|
||||
isarray@0.0.1:
|
||||
version "0.0.1"
|
||||
resolved "https://registry.yarnpkg.com/isarray/-/isarray-0.0.1.tgz#8a18acfca9a8f4177e09abfc6038939b05d1eedf"
|
||||
|
|
@ -13455,11 +13476,6 @@ kdbush@^3.0.0:
|
|||
resolved "https://registry.yarnpkg.com/kdbush/-/kdbush-3.0.0.tgz#f8484794d47004cc2d85ed3a79353dbe0abc2bf0"
|
||||
integrity sha512-hRkd6/XW4HTsA9vjVpY9tuXJYLSlelnkTmVFu4M9/7MIYQtFcHpbugAU7UbOfjOiVSVYl2fqgBuJ32JUmRo5Ew==
|
||||
|
||||
kew@^0.7.0:
|
||||
version "0.7.0"
|
||||
resolved "https://registry.yarnpkg.com/kew/-/kew-0.7.0.tgz#79d93d2d33363d6fdd2970b335d9141ad591d79b"
|
||||
integrity sha1-edk9LTM2PW/dKXCzNdkUGtWR15s=
|
||||
|
||||
keymirror@0.1.1, keymirror@^0.1.1:
|
||||
version "0.1.1"
|
||||
resolved "https://registry.yarnpkg.com/keymirror/-/keymirror-0.1.1.tgz#918889ea13f8d0a42e7c557250eee713adc95c35"
|
||||
|
|
@ -20835,6 +20851,14 @@ tar@^4:
|
|||
safe-buffer "^5.1.2"
|
||||
yallist "^3.0.2"
|
||||
|
||||
tcp-port-used@^1.0.1:
|
||||
version "1.0.1"
|
||||
resolved "https://registry.yarnpkg.com/tcp-port-used/-/tcp-port-used-1.0.1.tgz#46061078e2d38c73979a2c2c12b5a674e6689d70"
|
||||
integrity sha512-rwi5xJeU6utXoEIiMvVBMc9eJ2/ofzB+7nLOdnZuFTmNCLqRiQh2sMG9MqCxHU/69VC/Fwp5dV9306Qd54ll1Q==
|
||||
dependencies:
|
||||
debug "4.1.0"
|
||||
is2 "2.0.1"
|
||||
|
||||
teamwork@3.x.x:
|
||||
version "3.0.1"
|
||||
resolved "https://registry.yarnpkg.com/teamwork/-/teamwork-3.0.1.tgz#ff38c7161f41f8070b7813716eb6154036ece196"
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue