github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-25 10:23:14 -04:00
Code Issues Projects Releases Packages Wiki Activity

[7.x] Fix memory leak in query_string_input (#77649) (#77778)

Browse source
This commit is contained in:
Michail Yasonik 2020-09-17 13:11:17 -04:00 • committed by GitHub
parent 3d6253f90c
commit a834c20661
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

9
src/plugins/data/public/ui/query_string_input/query_string_input.tsx
View file

@ -546,13 +546,16 @@ export class QueryStringInputUI extends Component<Props, State> {
this.updateSuggestions.cancel(); this.updateSuggestions.cancel();
this.componentIsUnmounting = true; this.componentIsUnmounting = true;
window.removeEventListener('resize', this.handleAutoHeight); window.removeEventListener('resize', this.handleAutoHeight);
window.removeEventListener('scroll', this.handleListUpdate); window.removeEventListener('scroll', this.handleListUpdate, { capture: true });
} }
handleListUpdate = () => handleListUpdate = () => {
this.setState({ if (this.componentIsUnmounting) return;
return this.setState({
queryBarRect: this.queryBarInputDivRefInstance.current?.getBoundingClientRect(), queryBarRect: this.queryBarInputDivRefInstance.current?.getBoundingClientRect(),
}); });
};
handleAutoHeight = () => { handleAutoHeight = () => {
if (this.inputRef !== null && document.activeElement === this.inputRef) { if (this.inputRef !== null && document.activeElement === this.inputRef) {