github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 09:48:58 -04:00
Code Issues Projects Releases Packages Wiki Activity

[ES|QL] Inline editing flyout styles (#179953)

Browse source 
## Summary

The EuiThemeProvider messes up with our custom styles for some reason. I
am using the kibanaThemeProvider which is used across Lens and doesnt
create the problem

![image
(31)](e6a16840-8beb-4a89-bc97-e97608fe5210)
![image
(30)](5f1f2041-9859-4164-8f21-c2c42e492cad)
This commit is contained in:
Stratoula Kalafateli 2024-04-03 21:42:22 +02:00 • committed by GitHub
parent 2c405897ea
commit a85ba2b7ee
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 4 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

9
x-pack/plugins/lens/public/app_plugin/shared/edit_on_the_fly/get_edit_lens_configuration.tsx
View file

@ -6,14 +6,14 @@
*/
import React, { useCallback, useState } from 'react';
import { EuiFlyout, EuiLoadingSpinner, EuiOverlayMask, EuiThemeProvider } from '@elastic/eui';
import { EuiFlyout, EuiLoadingSpinner, EuiOverlayMask } from '@elastic/eui';
import { i18n } from '@kbn/i18n';
import { I18nProvider } from '@kbn/i18n-react';
import { Provider } from 'react-redux';
import type { MiddlewareAPI, Dispatch, Action } from '@reduxjs/toolkit';
import { css } from '@emotion/react';
import type { CoreStart } from '@kbn/core/public';
import { KibanaContextProvider } from '@kbn/kibana-react-plugin/public';
import { KibanaContextProvider, KibanaThemeProvider } from '@kbn/kibana-react-plugin/public';
import { isEqual } from 'lodash';
import { RootDragDropProvider } from '@kbn/dom-drag-drop';
import type { LensPluginStartDependencies } from '../../../plugin';
@ -99,7 +99,6 @@ export async function getEditLensConfiguration(
startDependencies,
getLensAttributeService(coreStart, startDependencies)
);
const theme = coreStart.theme.getTheme();
return ({
attributes,
@ -224,7 +223,7 @@ export async function getEditLensConfiguration(
return getWrapper(
<Provider store={lensStore}>
<EuiThemeProvider colorMode={theme.darkMode ? 'dark' : 'light'}>
<KibanaThemeProvider theme$={coreStart.theme.theme$}>
<I18nProvider>
<KibanaContextProvider services={lensServices}>
<RootDragDropProvider>
@ -232,7 +231,7 @@ export async function getEditLensConfiguration(
</RootDragDropProvider>
</KibanaContextProvider>
</I18nProvider>
</EuiThemeProvider>
</KibanaThemeProvider>
</Provider>
);
};