github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 09:48:58 -04:00
Code Issues Projects Releases Packages Wiki Activity

[ML] Fix for constant polling of deleting job tasks (#38013) (#38103)

Browse source 
* [ML] Fix for constant polling of deleting job tasks

* fixing comment
This commit is contained in:
James Gowdy 2019-06-05 15:39:43 +01:00 • committed by GitHub
parent 0c89b8efc7
commit a9449a4d9a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 16 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

26
x-pack/plugins/ml/public/jobs/jobs_list/components/jobs_list_view/jobs_list_view.js
View file

@ -95,6 +95,7 @@ export class JobsListView extends Component {
componentWillUnmount() {
timefilter.off('refreshIntervalUpdate');
deletingJobsRefreshTimeout = null;
this.clearRefreshInterval();
}
@ -126,7 +127,7 @@ export class JobsListView extends Component {
} else {
this.setRefreshInterval(value);
}
this.refreshJobSummaryList(true);
this.refreshJobSummaryList();
}
setRefreshInterval(interval) {
@ -317,7 +318,7 @@ export class JobsListView extends Component {
// if there are some jobs in a deleting state, start polling for
// deleting jobs so we can update the jobs list once the
// deleting tasks are over
this.checkDeletingJobTasks();
this.checkDeletingJobTasks(forceRefresh);
}
} catch (error) {
console.error(error);
@ -326,17 +327,22 @@ export class JobsListView extends Component {
}
}
async checkDeletingJobTasks() {
const { jobIds } = await ml.jobs.deletingJobTasks();
async checkDeletingJobTasks(forceRefresh = false) {
const { jobIds: taskJobIds } = await ml.jobs.deletingJobTasks();
if (jobIds.length === 0 || isEqual(jobIds.sort(), this.state.deletingJobIds.sort())) {
this.setState({
deletingJobIds: jobIds,
});
this.refreshJobSummaryList(true);
const taskListHasChanged = (isEqual(taskJobIds.sort(), this.state.deletingJobIds.sort()) === false);
this.setState({
deletingJobIds: taskJobIds,
});
// only reload the jobs list if the contents of the task list has changed
// or the check refresh has been forced i.e. from a user action
if (taskListHasChanged || forceRefresh) {
this.refreshJobSummaryList();
}
if (jobIds.length > 0 && deletingJobsRefreshTimeout === null) {
if (taskJobIds.length > 0 && deletingJobsRefreshTimeout === null) {
deletingJobsRefreshTimeout = setTimeout(() => {
deletingJobsRefreshTimeout = null;
this.checkDeletingJobTasks();