[Discover] Improve the copy when reaching the limit of discover:sampleSize (#155533)

Closes https://github.com/elastic/kibana/issues/154186

This PR removes a link to Advanced Settings from the copy.

<img width="998" alt="Screenshot 2023-04-21 at 18 01 14"
src="https://user-images.githubusercontent.com/1415710/233683075-3e87c451-7ff2-49e4-ae5f-89c3eff12153.png">

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

src/plugins/discover/public/components/discover_grid/discover_grid.tsx

@@ -20,7 +20,6 @@ import {
   EuiLoadingSpinner,
   EuiIcon,
   EuiDataGridRefProps,
-  EuiLink,
 } from '@elastic/eui';
 import type { DataView } from '@kbn/data-views-plugin/public';
 import type { SortOrder } from '@kbn/saved-search-plugin/public';
@@ -43,7 +42,6 @@ import { GRID_STYLE, toolbarVisibility as toolbarVisibilityDefaults } from './co
 import { getDisplayedColumns } from '../../utils/columns';
 import {
   DOC_HIDE_TIME_COLUMN_SETTING,
-  SAMPLE_SIZE_SETTING,
   MAX_DOC_FIELDS_DISPLAYED,
   SHOW_MULTIFIELDS,
 } from '../../../common';
@@ -613,23 +611,10 @@ export const DiscoverGrid = ({
         {showDisclaimer && (
           <p className="dscDiscoverGrid__footer" data-test-subj="discoverTableFooter">
             <FormattedMessage
-              id="discover.gridSampleSize.description"
-              defaultMessage="You're viewing the first {sampleSize} documents that match your search. To change this value, go to {advancedSettingsLink}."
+              id="discover.gridSampleSize.limitDescription"
+              defaultMessage="Search results are limited to {sampleSize} documents. Add more search terms to narrow your search."
               values={{
                 sampleSize,
-                advancedSettingsLink: (
-                  <EuiLink
-                    href={services.addBasePath(
-                      `/app/management/kibana/settings?query=${SAMPLE_SIZE_SETTING}`
-                    )}
-                    data-test-subj="discoverTableSampleSizeSettingsLink"
-                  >
-                    <FormattedMessage
-                      id="discover.gridSampleSize.advancedSettingsLinkLabel"
-                      defaultMessage="Advanced Settings"
-                    />
-                  </EuiLink>
-                ),
               }}
             />
           </p>

test/functional/apps/discover/group2/_data_grid_pagination.ts

@@ -64,7 +64,6 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
       // footer is shown now
       await retry.try(async function () {
         await testSubjects.existOrFail('discoverTableFooter');
-        await testSubjects.existOrFail('discoverTableSampleSizeSettingsLink');
       });
     });
 

x-pack/plugins/translations/translations/fr-FR.json

@@ -2151,7 +2151,6 @@
     "discover.grid.copyColumnValuesToClipboard.toastTitle": "Valeurs de la colonne \"{column}\" copiées dans le presse-papiers",
     "discover.grid.filterForAria": "Filtrer sur cette {value}",
     "discover.grid.filterOutAria": "Exclure cette {value}",
-    "discover.gridSampleSize.description": "Vous voyez les {sampleSize} premiers documents qui correspondent à votre recherche. Pour modifier cette valeur, accédez à {advancedSettingsLink}.",
     "discover.howToSeeOtherMatchingDocumentsDescription": "Voici les {sampleSize} premiers documents correspondant à votre recherche. Veuillez affiner cette dernière pour en voir davantage.",
     "discover.noMatchRoute.bannerText": "L'application Discover ne reconnaît pas cet itinéraire : {route}",
     "discover.noResults.kqlExamples.kqlDescription": "En savoir plus sur {kqlLink}",
@@ -2371,7 +2370,6 @@
     "discover.grid.tableRow.viewSurroundingDocumentsLinkTextSimple": "Documents relatifs",
     "discover.grid.tableRow.viewText": "Afficher :",
     "discover.grid.viewDoc": "Afficher/Masquer les détails de la boîte de dialogue",
-    "discover.gridSampleSize.advancedSettingsLinkLabel": "Paramètres avancés",
     "discover.helpMenu.appName": "Découverte",
     "discover.inspectorRequestDataTitleDocuments": "Documents",
     "discover.inspectorRequestDescriptionDocument": "Cette requête interroge Elasticsearch afin de récupérer les documents.",

x-pack/plugins/translations/translations/ja-JP.json

@@ -2151,7 +2151,6 @@
     "discover.grid.copyColumnValuesToClipboard.toastTitle": "\"{column}\"列の値がクリップボードにコピーされました",
     "discover.grid.filterForAria": "この{value}でフィルターを適用",
     "discover.grid.filterOutAria": "この{value}を除外",
-    "discover.gridSampleSize.description": "検索と一致する最初の{sampleSize}ドキュメントを表示しています。この値を変更するには、{advancedSettingsLink}に移動します。",
     "discover.howToSeeOtherMatchingDocumentsDescription": "これらは検索条件に一致した初めの{sampleSize}件のドキュメントです。他の結果を表示するには検索条件を絞ってください。",
     "discover.noMatchRoute.bannerText": "Discoverアプリケーションはこのルートを認識できません：{route}",
     "discover.noResults.kqlExamples.kqlDescription": "{kqlLink}の詳細",
@@ -2371,7 +2370,6 @@
     "discover.grid.tableRow.viewSurroundingDocumentsLinkTextSimple": "周りのドキュメント",
     "discover.grid.tableRow.viewText": "表示：",
     "discover.grid.viewDoc": "詳細ダイアログを切り替え",
-    "discover.gridSampleSize.advancedSettingsLinkLabel": "高度な設定",
     "discover.helpMenu.appName": "Discover",
     "discover.inspectorRequestDataTitleDocuments": "ドキュメント",
     "discover.inspectorRequestDescriptionDocument": "このリクエストはElasticsearchにクエリをかけ、ドキュメントを取得します。",

x-pack/plugins/translations/translations/zh-CN.json

@@ -2151,7 +2151,6 @@
     "discover.grid.copyColumnValuesToClipboard.toastTitle": "“{column}”列的值已复制到剪贴板",
     "discover.grid.filterForAria": "筛留此 {value}",
     "discover.grid.filterOutAria": "筛除此 {value}",
-    "discover.gridSampleSize.description": "您正查看与您的搜索相匹配的前 {sampleSize} 个文档。要更改此值，请前往 {advancedSettingsLink}",
     "discover.howToSeeOtherMatchingDocumentsDescription": "以下是匹配您的搜索的前 {sampleSize} 个文档，请优化您的搜索以查看其他文档。",
     "discover.noMatchRoute.bannerText": "Discover 应用程序无法识别此路由：{route}",
     "discover.noResults.kqlExamples.kqlDescription": "详细了解 {kqlLink}",
@@ -2371,7 +2370,6 @@
     "discover.grid.tableRow.viewSurroundingDocumentsLinkTextSimple": "周围文档",
     "discover.grid.tableRow.viewText": "视图：",
     "discover.grid.viewDoc": "切换具有详情的对话框",
-    "discover.gridSampleSize.advancedSettingsLinkLabel": "高级设置",
     "discover.helpMenu.appName": "Discover",
     "discover.inspectorRequestDataTitleDocuments": "文档",
     "discover.inspectorRequestDescriptionDocument": "此请求将查询 Elasticsearch 以获取文档。",