github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 01:38:56 -04:00
Code Issues Projects Releases Packages Wiki Activity

Fixed regex bug in Safari (#89399) (#89421)

Browse source 
* Fixed regex bug in Safari

* Added extra unit test
This commit is contained in:
Thom Heymann 2021-01-28 00:00:22 +00:00 • committed by GitHub
parent fb74c3cfeb
commit aaed92a0a1
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
x-pack/plugins/security/common/constants.ts
View file

@ -29,7 +29,7 @@ export const NEXT_URL_QUERY_STRING_PARAMETER = 'next';
* - Must contain only letters, numbers, spaces, punctuation and printable symbols.
* - Must not contain leading or trailing spaces.
*/
export const NAME_REGEX = /^(?! )[a-zA-Z0-9 !"#$%&'()*+,\-./\\:;<=>?@\[\]^_`{|}~]+(?<! )$/;
export const NAME_REGEX = /^(?! )[a-zA-Z0-9 !"#$%&'()*+,\-./\\:;<=>?@\[\]^_`{|}~]*[a-zA-Z0-9!"#$%&'()*+,\-./\\:;<=>?@\[\]^_`{|}~]$/;
/**
* Maximum length of usernames and role names.

6
x-pack/plugins/security/public/management/users/edit_user/create_user_page.test.tsx
View file

@ -88,6 +88,12 @@ describe('CreateUserPage', () => {
await findAllByText(/Username must not contain leading or trailing spaces/i);
fireEvent.change(await findByLabelText('Username'), {
target: { value: 'username_with_trailing_space ' },
});
await findAllByText(/Username must not contain leading or trailing spaces/i);
fireEvent.change(await findByLabelText('Username'), {
target: { value: '€' },
});