[8.x][ci] Run type checking before tests (#197539) (#198424)

#197539
2025-04-23 09:19:04 -04:00 · 2024-10-31 12:22:42 -05:00 · 2024-10-31 12:22:42 -05:00 · ab50ac7935
commit ab50ac7935
parent 18418a05e7
28 changed files with 63 additions and 91 deletions
--- a/.buildkite/pipelines/on_merge.yml
+++ b/.buildkite/pipelines/on_merge.yml
@ -39,7 +39,6 @@ steps:
      provider: gcp
      machineType: n2-highcpu-8
      preemptible: true
-    key: quick_checks
    timeout_in_minutes: 60
    retry:
      automatic:
@ -54,7 +53,6 @@ steps:
      provider: gcp
      machineType: n2-standard-16
      preemptible: true
-    key: linting
    timeout_in_minutes: 60
    retry:
      automatic:
@ -69,8 +67,23 @@ steps:
      provider: gcp
      machineType: n2-standard-32
      preemptible: true
-    key: linting_with_types
-    timeout_in_minutes: 90
+    timeout_in_minutes: 60
+    retry:
+      automatic:
+        - exit_status: '-1'
+          limit: 3
+
+  - command: .buildkite/scripts/steps/check_types.sh
+    label: 'Check Types'
+    agents:
+      image: family/kibana-ubuntu-2004
+      imageProject: elastic-images-prod
+      provider: gcp
+      machineType: c4-standard-4
+      diskType: 'hyperdisk-balanced'
+      preemptible: true
+      spotZones: us-central1-a,us-central1-b,us-central1-c
+    timeout_in_minutes: 60
    retry:
      automatic:
        - exit_status: '-1'
@ -136,11 +149,6 @@ steps:
      provider: gcp
      machineType: n2-standard-4
      preemptible: true
-    depends_on:
-      - build
-      - quick_checks
-      - linting
-      - linting_with_types
    timeout_in_minutes: 60
    parallelism: 2
    retry:
@ -156,11 +164,6 @@ steps:
      provider: gcp
      machineType: n2-standard-4
      preemptible: true
-    depends_on:
-      - build
-      - quick_checks
-      - linting
-      - linting_with_types
    timeout_in_minutes: 60
    parallelism: 4
    retry:
@ -176,11 +179,6 @@ steps:
      provider: gcp
      machineType: n2-standard-4
      preemptible: true
-    depends_on:
-      - build
-      - quick_checks
-      - linting
-      - linting_with_types
    timeout_in_minutes: 60
    parallelism: 6
    retry:
@ -196,11 +194,6 @@ steps:
      provider: gcp
      machineType: n2-standard-4
      preemptible: true
-    depends_on:
-      - build
-      - quick_checks
-      - linting
-      - linting_with_types
    timeout_in_minutes: 60
    parallelism: 5
    retry:
@ -216,11 +209,6 @@ steps:
      provider: gcp
      machineType: n2-standard-4
      preemptible: true
-    depends_on:
-      - build
-      - quick_checks
-      - linting
-      - linting_with_types
    timeout_in_minutes: 60
    parallelism: 6
    retry:
@ -236,11 +224,6 @@ steps:
      provider: gcp
      machineType: n2-standard-4
      preemptible: true
-    depends_on:
-      - build
-      - quick_checks
-      - linting
-      - linting_with_types
    timeout_in_minutes: 60
    parallelism: 1
    retry:
@ -256,11 +239,6 @@ steps:
      provider: gcp
      machineType: n2-standard-4
      preemptible: true
-    depends_on:
-      - build
-      - quick_checks
-      - linting
-      - linting_with_types
    timeout_in_minutes: 60
    parallelism: 2
    retry:
@ -276,11 +254,6 @@ steps:
      provider: gcp
      machineType: n2-standard-4
      preemptible: true
-    depends_on:
-      - build
-      - quick_checks
-      - linting
-      - linting_with_types
    timeout_in_minutes: 60
    parallelism: 2
    retry:
@ -296,11 +269,6 @@ steps:
      provider: gcp
      machineType: n2-standard-4
      preemptible: true
-    depends_on:
-      - build
-      - quick_checks
-      - linting
-      - linting_with_types
    timeout_in_minutes: 60
    parallelism: 6
    retry:
@ -316,11 +284,6 @@ steps:
      provider: gcp
      machineType: n2-standard-4
      preemptible: true
-    depends_on:
-      - build
-      - quick_checks
-      - linting
-      - linting_with_types
    timeout_in_minutes: 60
    parallelism: 8
    retry:
@ -338,11 +301,6 @@ steps:
      localSsds: 1
      localSsdInterface: nvme
      machineType: n2-standard-4
-    depends_on:
-      - build
-      - quick_checks
-      - linting
-      - linting_with_types
    timeout_in_minutes: 60
    parallelism: 20
    retry:
@ -353,11 +311,6 @@ steps:
  - command: '.buildkite/scripts/steps/functional/on_merge_unsupported_ftrs.sh'
    label: Trigger unsupported ftr tests
    timeout_in_minutes: 10
-    depends_on:
-      - build
-      - quick_checks
-      - linting
-      - linting_with_types
    agents:
      image: family/kibana-ubuntu-2004
      imageProject: elastic-images-prod
@ -378,20 +331,6 @@ steps:
        - exit_status: '-1'
          limit: 3

-  - command: .buildkite/scripts/steps/check_types.sh
-    label: 'Check Types'
-    agents:
-      image: family/kibana-ubuntu-2004
-      imageProject: elastic-images-prod
-      provider: gcp
-      machineType: n2-standard-4
-      preemptible: true
-    timeout_in_minutes: 70
-    retry:
-      automatic:
-        - exit_status: '-1'
-          limit: 3
-
  - command: .buildkite/scripts/steps/checks/capture_oas_snapshot.sh
    label: 'Check OAS Snapshot'
    agents:
--- a/.buildkite/pipelines/pull_request/apm_cypress.yml
+++ b/.buildkite/pipelines/pull_request/apm_cypress.yml
@ -9,6 +9,7 @@ steps:
      - quick_checks
      - linting
      - linting_with_types
+      - check_types
    timeout_in_minutes: 120
    parallelism: 1 # TODO: Set parallelism when apm_cypress handles it
    retry:
--- a/.buildkite/pipelines/pull_request/base.yml
+++ b/.buildkite/pipelines/pull_request/base.yml
@ -50,7 +50,21 @@ steps:
      machineType: n2-standard-32
      preemptible: true
    key: linting_with_types
-    timeout_in_minutes: 90
+    timeout_in_minutes: 60
+    retry:
+      automatic:
+        - exit_status: '-1'
+          limit: 3
+
+  - command: .buildkite/scripts/steps/check_types.sh
+    label: 'Check Types'
+    agents:
+      machineType: c4-standard-4
+      diskType: 'hyperdisk-balanced'
+      preemptible: true
+      spotZones: us-central1-a,us-central1-b,us-central1-c
+    key: check_types
+    timeout_in_minutes: 60
    retry:
      automatic:
        - exit_status: '-1'
@ -85,18 +99,6 @@ steps:
        - exit_status: '*'
          limit: 1

-  - command: .buildkite/scripts/steps/check_types.sh
-    label: 'Check Types'
-    agents:
-      machineType: n2-standard-4
-      preemptible: true
-    key: check_types
-    timeout_in_minutes: 70
-    retry:
-      automatic:
-        - exit_status: '-1'
-          limit: 3
-
  - command: .buildkite/scripts/steps/checks.sh
    label: 'Checks'
    key: checks
--- a/.buildkite/pipelines/pull_request/deploy_cloud.yml
+++ b/.buildkite/pipelines/pull_request/deploy_cloud.yml
@ -9,6 +9,7 @@ steps:
      - quick_checks
      - linting
      - linting_with_types
+      - check_types
    timeout_in_minutes: 30
    soft_fail: true
    retry:
--- a/.buildkite/pipelines/pull_request/exploratory_view_plugin.yml
+++ b/.buildkite/pipelines/pull_request/exploratory_view_plugin.yml
@ -9,6 +9,7 @@ steps:
      - quick_checks
      - linting
      - linting_with_types
+      - check_types
    timeout_in_minutes: 60
    artifact_paths:
      - 'x-pack/plugins/observability_solution/exploratory_view/e2e/.journeys/**/*'
--- a/.buildkite/pipelines/pull_request/fips.yml
+++ b/.buildkite/pipelines/pull_request/fips.yml
@ -9,6 +9,7 @@ steps:
      - quick_checks
      - linting
      - linting_with_types
+      - check_types
    timeout_in_minutes: 60
    soft_fail: true
    retry:
--- a/.buildkite/pipelines/pull_request/fleet_cypress.yml
+++ b/.buildkite/pipelines/pull_request/fleet_cypress.yml
@ -9,6 +9,7 @@ steps:
      - quick_checks
      - linting
      - linting_with_types
+      - check_types
    timeout_in_minutes: 50
    parallelism: 6
    retry:
--- a/.buildkite/pipelines/pull_request/inventory_cypress.yml
+++ b/.buildkite/pipelines/pull_request/inventory_cypress.yml
@ -9,6 +9,7 @@ steps:
      - quick_checks
      - linting
      - linting_with_types
+      - check_types
    timeout_in_minutes: 120
    parallelism: 1
    retry:
--- a/.buildkite/pipelines/pull_request/kbn_handlebars.yml
+++ b/.buildkite/pipelines/pull_request/kbn_handlebars.yml
@ -9,6 +9,7 @@ steps:
      - quick_checks
      - linting
      - linting_with_types
+      - check_types
    timeout_in_minutes: 5
    retry:
      automatic:
--- a/.buildkite/pipelines/pull_request/observability_onboarding_cypress.yml
+++ b/.buildkite/pipelines/pull_request/observability_onboarding_cypress.yml
@ -9,6 +9,7 @@ steps:
      - quick_checks
      - linting
      - linting_with_types
+      - check_types
    timeout_in_minutes: 120
    retry:
      automatic:
--- a/.buildkite/pipelines/pull_request/profiling_cypress.yml
+++ b/.buildkite/pipelines/pull_request/profiling_cypress.yml
@ -9,6 +9,7 @@ steps:
      - quick_checks
      - linting
      - linting_with_types
+      - check_types
    timeout_in_minutes: 120
    parallelism: 2
    retry:
--- a/.buildkite/pipelines/pull_request/response_ops.yml
+++ b/.buildkite/pipelines/pull_request/response_ops.yml
@ -9,6 +9,7 @@ steps:
      - quick_checks
      - linting
      - linting_with_types
+      - check_types
    timeout_in_minutes: 120
    parallelism: 9
    retry:
--- a/.buildkite/pipelines/pull_request/response_ops_cases.yml
+++ b/.buildkite/pipelines/pull_request/response_ops_cases.yml
@ -9,6 +9,7 @@ steps:
      - quick_checks
      - linting
      - linting_with_types
+      - check_types
    timeout_in_minutes: 120
    retry:
      automatic:
--- a/.buildkite/pipelines/pull_request/security_solution/ai_assistant.yml
+++ b/.buildkite/pipelines/pull_request/security_solution/ai_assistant.yml
@ -9,6 +9,7 @@ steps:
      - quick_checks
      - linting
      - linting_with_types
+      - check_types
    timeout_in_minutes: 60
    parallelism: 1
    retry:
--- a/.buildkite/pipelines/pull_request/security_solution/cloud_security_posture.yml
+++ b/.buildkite/pipelines/pull_request/security_solution/cloud_security_posture.yml
@ -9,6 +9,7 @@ steps:
      - quick_checks
      - linting
      - linting_with_types
+      - check_types
    timeout_in_minutes: 60
    parallelism: 1
    retry:
@ -26,6 +27,7 @@ steps:
      - quick_checks
      - linting
      - linting_with_types
+      - check_types
    timeout_in_minutes: 60
    parallelism: 1
    retry:
--- a/.buildkite/pipelines/pull_request/security_solution/cypress_burn.yml
+++ b/.buildkite/pipelines/pull_request/security_solution/cypress_burn.yml
@ -11,6 +11,7 @@ steps:
      - quick_checks
      - linting
      - linting_with_types
+      - check_types
    timeout_in_minutes: 60
    soft_fail: true
    parallelism: 1
@ -27,6 +28,7 @@ steps:
      - quick_checks
      - linting
      - linting_with_types
+      - check_types
    timeout_in_minutes: 60
    parallelism: 1
    retry:
@ -43,6 +45,7 @@ steps:
      - quick_checks
      - linting
      - linting_with_types
+      - check_types
    timeout_in_minutes: 50
    soft_fail: true
    retry:
--- a/.buildkite/pipelines/pull_request/security_solution/defend_workflows.yml
+++ b/.buildkite/pipelines/pull_request/security_solution/defend_workflows.yml
@ -11,6 +11,7 @@ steps:
      - quick_checks
      - linting
      - linting_with_types
+      - check_types
    timeout_in_minutes: 60
    parallelism: 20
    retry:
--- a/.buildkite/pipelines/pull_request/security_solution/detection_engine.yml
+++ b/.buildkite/pipelines/pull_request/security_solution/detection_engine.yml
@ -9,6 +9,7 @@ steps:
      - quick_checks
      - linting
      - linting_with_types
+      - check_types
    timeout_in_minutes: 60
    parallelism: 5
    retry:
@ -26,6 +27,7 @@ steps:
      - quick_checks
      - linting
      - linting_with_types
+      - check_types
    timeout_in_minutes: 60
    parallelism: 2
    retry:
--- a/.buildkite/pipelines/pull_request/security_solution/entity_analytics.yml
+++ b/.buildkite/pipelines/pull_request/security_solution/entity_analytics.yml
@ -9,6 +9,7 @@ steps:
      - quick_checks
      - linting
      - linting_with_types
+      - check_types
    timeout_in_minutes: 60
    parallelism: 2
    retry:
--- a/.buildkite/pipelines/pull_request/security_solution/explore.yml
+++ b/.buildkite/pipelines/pull_request/security_solution/explore.yml
@ -9,6 +9,7 @@ steps:
      - quick_checks
      - linting
      - linting_with_types
+      - check_types
    timeout_in_minutes: 60
    parallelism: 2
    retry:
--- a/.buildkite/pipelines/pull_request/security_solution/investigations.yml
+++ b/.buildkite/pipelines/pull_request/security_solution/investigations.yml
@ -9,6 +9,7 @@ steps:
      - quick_checks
      - linting
      - linting_with_types
+      - check_types
    timeout_in_minutes: 60
    parallelism: 7
    retry:
--- a/.buildkite/pipelines/pull_request/security_solution/osquery_cypress.yml
+++ b/.buildkite/pipelines/pull_request/security_solution/osquery_cypress.yml
@ -9,6 +9,7 @@ steps:
      - quick_checks
      - linting
      - linting_with_types
+      - check_types
    timeout_in_minutes: 60
    parallelism: 8
    retry:
--- a/.buildkite/pipelines/pull_request/security_solution/playwright.yml
+++ b/.buildkite/pipelines/pull_request/security_solution/playwright.yml
@ -9,6 +9,7 @@ steps:
      - quick_checks
      - linting
      - linting_with_types
+      - check_types
    timeout_in_minutes: 60
    parallelism: 1
    retry:
--- a/.buildkite/pipelines/pull_request/security_solution/rule_management.yml
+++ b/.buildkite/pipelines/pull_request/security_solution/rule_management.yml
@ -9,6 +9,7 @@ steps:
      - quick_checks
      - linting
      - linting_with_types
+      - check_types
    timeout_in_minutes: 60
    parallelism: 4
    retry:
@ -26,6 +27,7 @@ steps:
      - quick_checks
      - linting
      - linting_with_types
+      - check_types
    timeout_in_minutes: 60
    parallelism: 2
    retry:
--- a/.buildkite/pipelines/pull_request/slo_plugin_e2e.yml
+++ b/.buildkite/pipelines/pull_request/slo_plugin_e2e.yml
@ -9,6 +9,7 @@ steps:
      - quick_checks
      - linting
      - linting_with_types
+      - check_types
    timeout_in_minutes: 30
    artifact_paths:
      - 'x-pack/plugins/observability_solution/slo/e2e/.journeys/**/*'
--- a/.buildkite/pipelines/pull_request/synthetics_plugin.yml
+++ b/.buildkite/pipelines/pull_request/synthetics_plugin.yml
@ -9,6 +9,7 @@ steps:
      - quick_checks
      - linting
      - linting_with_types
+      - check_types
    timeout_in_minutes: 60
    artifact_paths:
      - 'x-pack/plugins/observability_solution/synthetics/e2e/.journeys/**/*'
--- a/.buildkite/pipelines/pull_request/uptime_plugin.yml
+++ b/.buildkite/pipelines/pull_request/uptime_plugin.yml
@ -9,6 +9,7 @@ steps:
      - quick_checks
      - linting
      - linting_with_types
+      - check_types
    timeout_in_minutes: 60
    artifact_paths:
      - 'x-pack/plugins/observability_solution/synthetics/e2e/.journeys/**/*'
--- a/.buildkite/pipelines/pull_request/ux_plugin_e2e.yml
+++ b/.buildkite/pipelines/pull_request/ux_plugin_e2e.yml
@ -9,6 +9,7 @@ steps:
      - quick_checks
      - linting
      - linting_with_types
+      - check_types
    timeout_in_minutes: 60
    artifact_paths:
      - 'x-pack/plugins/observability_solution/ux/e2e/.journeys/**/*'