github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 09:48:58 -04:00
Code Issues Projects Releases Packages Wiki Activity

[Security Solution] Fix cell actions in Explore pages (#177478)

Browse source 
## Summary

issue: https://github.com/elastic/kibana/issues/177410

Adding `overflow: hidden` style was causing the cell actions to
disappear after the upgrade to [EUI upgrade to
v91.3.1](https://github.com/elastic/kibana/pull/173569)

The `overflow: hidden` style is no longer needed, it has been removed.
So cell actions are displayed
This commit is contained in:
Sergi Massaneda 2024-02-21 18:52:45 +01:00 • committed by GitHub
parent 81bccc5a81
commit ab864b4ccc
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 4 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

18
x-pack/packages/security-solution/data_table/components/data_table/helpers.tsx
View file

@ -85,25 +85,13 @@ export const mapSortingColumns = ({
export const addBuildingBlockStyle = (
ecs: Ecs,
theme: EuiTheme,
setCellProps: EuiDataGridCellValueElementProps['setCellProps'],
defaultStyles?: React.CSSProperties
setCellProps: EuiDataGridCellValueElementProps['setCellProps']
) => {
const currentStyles = defaultStyles ?? {};
if (isEventBuildingBlockType(ecs)) {
setCellProps({
style: {
...currentStyles,
backgroundColor: `${theme.eui.euiColorHighlight}`,
},
});
setCellProps({ style: { backgroundColor: `${theme.eui.euiColorHighlight}` } });
} else {
// reset cell style
setCellProps({
style: {
...currentStyles,
backgroundColor: 'inherit',
},
});
setCellProps({ style: { backgroundColor: 'inherit' } });
}
};

4
x-pack/packages/security-solution/data_table/components/data_table/index.tsx
View file

@ -410,10 +410,8 @@ export const DataTableComponent = React.memo<DataTableProps>(
const ecs = pageRowIndex < data.length ? data[pageRowIndex].ecs : null;
useEffect(() => {
const defaultStyles = { overflow: 'hidden' };
setCellProps({ style: { ...defaultStyles } });
if (ecs && rowData) {
addBuildingBlockStyle(ecs, theme, setCellProps, defaultStyles);
addBuildingBlockStyle(ecs, theme, setCellProps);
} else {
// disable the cell when it has no data
setCellProps({ style: { display: 'none' } });