github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-23 09:19:04 -04:00
Code Issues Projects Releases Packages Wiki Activity

Remove default_field from query:queryString:options (#18966)

Browse source
This commit is contained in:
Matt Bargar 2018-05-10 17:37:00 -04:00 • committed by GitHub
parent d641bfa358
commit abc2a5c4a3
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 15 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

15
docs/migration/migrate_7_0.asciidoc
View file

@ -27,4 +27,17 @@ conflicted with the Advanced Setting. In 7.0 `query:queryString:options` will no
users can have full control over their custom filters.
*Impact:* You must ensure that any saved searches with a `query_string` filter aren't relying implicitly on
`query:queryString:options`.
`query:queryString:options`.
[float]
=== Advanced setting query:queryString:options no longer applies `default_field: *` by default.
*Details:* Elasticsearch removed the ability to create indices with an _all field in 6.0. As a result, a user could end
up with a mix of indices with and without _all fields if they upgraded from an older version of ES. This could lead to
inconsistent highlighting in Discover. To work around this issue we added `default_field: *` to query:queryString:options
to force consistent querying across indices with and without _all. In 7.0 the _all field will be gone from all indices
so we no longer need this workaround.
*Impact:* Since we'll no longer send the `default_field` parameter in Kibana's query_string query, Elasticsearch
will use the index setting instead. The default for the index setting is also `*`, so most users should not be impacted.
If some of your indices have a non-default `default_field` setting, you may want to update it or re-add the parameter
to Kibana's advanced setting.

2
src/core_plugins/kibana/ui_setting_defaults.js
View file

@ -15,7 +15,7 @@ export function getUiSettingDefaults() {
},
'query:queryString:options': {
name: 'Query string options',
value: '{ "analyze_wildcard": true, "default_field": "*" }',
value: '{ "analyze_wildcard": true }',
description: '<a href="https://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl-query-string-query.html" target="_blank" rel="noopener noreferrer">Options</a> for the lucene query string parser',
type: 'json'
},