github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 09:48:58 -04:00
Code Issues Projects Releases Packages Wiki Activity

[Profiling] removing sampling rate from label (#160495)

Browse source 
<img width="1246" alt="Screenshot 2023-06-26 at 10 10 10 AM"
src="554c5849-7b0b-49fe-830e-747b91e65c5d">
This commit is contained in:
Cauê Marcondes 2023-06-27 08:52:34 +01:00 • committed by GitHub
parent ec962e05e6
commit ac288a106c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 21 deletions
Download patch file Download diff file Expand all files Collapse all files

28
x-pack/plugins/profiling/public/components/topn_functions/index.tsx
View file

@ -45,36 +45,24 @@ interface Row {
};
}
function getTotalSamplesLabel(samplingRate?: number) {
if (samplingRate === undefined) {
return i18n.translate('xpack.profiling.functionsView.totalSampleCountLabel', {
defaultMessage: 'Total sample estimate:',
});
}
return i18n.translate('xpack.profiling.functionsView.totalSampleCountLabelWithSamplingRate', {
defaultMessage: 'Total sample (estimate sample rate: {samplingRate}):',
values: { samplingRate },
});
}
function TotalSamplesStat({
totalSamples,
newSamples,
samplingRateA,
samplingRateB,
}: {
totalSamples: number;
newSamples: number | undefined;
samplingRateA: number;
samplingRateB: number | undefined;
}) {
const value = totalSamples.toLocaleString();
const sampleHeader = i18n.translate('xpack.profiling.functionsView.totalSampleCountLabel', {
defaultMessage: ' Total sample estimate: ',
});
if (newSamples === undefined || newSamples === 0) {
return (
<EuiStat
title={<EuiText style={{ fontWeight: 'bold' }}>{value}</EuiText>}
description={getTotalSamplesLabel(samplingRateA)}
description={sampleHeader}
/>
);
}
@ -87,10 +75,10 @@ function TotalSamplesStat({
title={
<EuiText style={{ fontWeight: 'bold' }}>
{value}
<GetLabel value={percentDelta} prepend=" (" append=")" />
<GetLabel value={percentDelta} prepend="(" append=")" />
</EuiText>
}
description={getTotalSamplesLabel(samplingRateB)}
description={sampleHeader}
/>
);
}
@ -418,8 +406,6 @@ export function TopNFunctionsTable({
<TotalSamplesStat
totalSamples={totalCount}
newSamples={comparisonTopNFunctions?.TotalCount}
samplingRateA={topNFunctions?.SamplingRate ?? 1.0}
samplingRateB={comparisonTopNFunctions?.SamplingRate ?? 1.0}
/>
<EuiSpacer size="s" />
<EuiHorizontalRule margin="none" style={{ height: 2 }} />