github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-06-28 11:05:39 -04:00
Code Issues Projects Releases Packages Wiki Activity

[Security Solution] response action entity_id number -> string (#135037)

Browse source
This commit is contained in:
Joey F. Poon 2022-06-23 14:28:03 -05:00 • committed by GitHub
parent 61b5349d95
commit acfd0517a2
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 6 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

4
x-pack/plugins/security_solution/common/endpoint/schema/actions.test.ts
View file

@ -213,7 +213,7 @@ describe('actions schemas', () => {
KillOrSuspendProcessRequestSchema.body.validate({ KillOrSuspendProcessRequestSchema.body.validate({
endpoint_ids: ['ABC-XYZ-000'], endpoint_ids: ['ABC-XYZ-000'],
parameters: { parameters: {
entity_id: 5678, entity_id: 'abc123',
}, },
}); });
}).not.toThrow(); }).not.toThrow();
@ -225,7 +225,7 @@ describe('actions schemas', () => {
endpoint_ids: ['ABC-XYZ-000'], endpoint_ids: ['ABC-XYZ-000'],
parameters: { parameters: {
pid: 1234, pid: 1234,
entity_id: 5678, entity_id: 'abc123',
}, },
}); });
}).toThrow(); }).toThrow();

2
x-pack/plugins/security_solution/common/endpoint/schema/actions.ts
View file

@ -27,7 +27,7 @@ export const KillOrSuspendProcessRequestSchema = {
...BaseActionRequestSchema, ...BaseActionRequestSchema,
parameters: schema.oneOf([ parameters: schema.oneOf([
schema.object({ pid: schema.number({ min: 1 }) }), schema.object({ pid: schema.number({ min: 1 }) }),
schema.object({ entity_id: schema.number({ min: 1 }) }), schema.object({ entity_id: schema.string({ minLength: 1 }) }),
]), ]),
}), }),
}; };

2
x-pack/plugins/security_solution/common/endpoint/types/actions.ts
View file

@ -87,7 +87,7 @@ interface ResponseActionParametersWithPid {
interface ResponseActionParametersWithEntityId { interface ResponseActionParametersWithEntityId {
pid?: never; pid?: never;
entity_id: number; entity_id: string;
} }
export type ResponseActionParametersWithPidOrEntityId = export type ResponseActionParametersWithPidOrEntityId =

4
x-pack/test/security_solution_endpoint_api_int/apis/endpoint_authz.ts
View file

@ -94,12 +94,12 @@ export default function ({ getService }: FtrProviderContext) {
{ {
method: 'post', method: 'post',
path: KILL_PROCESS_ROUTE, path: KILL_PROCESS_ROUTE,
body: { endpoint_ids: ['one'], parameters: { entity_id: 1234 } }, body: { endpoint_ids: ['one'], parameters: { entity_id: 'abc123' } },
}, },
{ {
method: 'post', method: 'post',
path: SUSPEND_PROCESS_ROUTE, path: SUSPEND_PROCESS_ROUTE,
body: { endpoint_ids: ['one'], parameters: { entity_id: 1234 } }, body: { endpoint_ids: ['one'], parameters: { entity_id: 'abc123' } },
}, },
]; ];