github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 01:38:56 -04:00
Code Issues Projects Releases Packages Wiki Activity

Default scroll wheel zoom to false on vega maps. Update docs (#21169)

Browse source 
* Default scroll wheel zoom to false on vega maps. Update docs

* Update scroll wheel to false in tests
This commit is contained in:
Aaron Caldwell 2018-10-29 15:31:16 -06:00 • committed by GitHub
parent dc89a9dc61
commit ad10c758c0
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 7 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

3
docs/visualize/vega.asciidoc
View file

@ -215,7 +215,8 @@ the graph must specify `type=map` in the host configuration:
// defaults to true, shows +/- buttons to zoom in/out
"zoomControl": false,
// defaults to true, disables mouse wheel zoom
// Defaults to 'false', disables mouse wheel zoom. If set to
// 'true', map may zoom unexpectedly while scrolling dashboard
"scrollWheelZoom": false,
// When false, repaints on each move frame.

8
src/core_plugins/vega/public/data_model/__tests__/vega_parser.js
View file

@ -171,7 +171,7 @@ describe('VegaParser._parseMapConfig', () => {
longitude: 0,
mapStyle: 'default',
zoomControl: true,
scrollWheelZoom: true,
scrollWheelZoom: false,
}, 0));
it('filled', test({
@ -180,7 +180,7 @@ describe('VegaParser._parseMapConfig', () => {
longitude: 0,
mapStyle: 'default',
zoomControl: true,
scrollWheelZoom: true,
scrollWheelZoom: false,
maxBounds: [1, 2, 3, 4],
}, {
delayRepaint: true,
@ -188,7 +188,7 @@ describe('VegaParser._parseMapConfig', () => {
longitude: 0,
mapStyle: 'default',
zoomControl: true,
scrollWheelZoom: true,
scrollWheelZoom: false,
maxBounds: [1, 2, 3, 4],
}, 0));
@ -207,7 +207,7 @@ describe('VegaParser._parseMapConfig', () => {
longitude: 0,
mapStyle: 'default',
zoomControl: true,
scrollWheelZoom: true,
scrollWheelZoom: false,
}, 5));
});

2
src/core_plugins/vega/public/data_model/vega_parser.js
View file

@ -299,7 +299,7 @@ export class VegaParser {
}
this._parseBool('zoomControl', res, true);
this._parseBool('scrollWheelZoom', res, true);
this._parseBool('scrollWheelZoom', res, false);
const maxBounds = this._config.maxBounds;
if (maxBounds !== undefined) {