github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 01:38:56 -04:00
Code Issues Projects Releases Packages Wiki Activity

[8.10] fix(slo): sli value summary calculation (#164598) (#164698)

Browse source 
# Backport

This will backport the following commits from `main` to `8.10`:
- [fix(slo): sli value summary calculation
(#164598)](https://github.com/elastic/kibana/pull/164598)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Kevin
Delemme","email":"kevin.delemme@elastic.co"},"sourceCommit":{"committedDate":"2023-08-24T12:09:58Z","message":"fix(slo):
sli value summary calculation
(#164598)","sha":"37efbf350dbfd25374e74f843df927afd287f209","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["backport","release_note:skip","Team:
Actionable
Observability","v8.10.0","v8.11.0"],"number":164598,"url":"https://github.com/elastic/kibana/pull/164598","mergeCommit":{"message":"fix(slo):
sli value summary calculation
(#164598)","sha":"37efbf350dbfd25374e74f843df927afd287f209"}},"sourceBranch":"main","suggestedTargetBranches":["8.10"],"targetPullRequestStates":[{"branch":"8.10","label":"v8.10.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/164598","number":164598,"mergeCommit":{"message":"fix(slo):
sli value summary calculation
(#164598)","sha":"37efbf350dbfd25374e74f843df927afd287f209"}}]}]
BACKPORT-->

Co-authored-by: Kevin Delemme <kevin.delemme@elastic.co>
This commit is contained in:
Kibana Machine 2023-08-24 09:32:42 -04:00 • committed by GitHub
parent 4f9823ca9c
commit af08fbdcd1
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
11 changed files with 15 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

10
x-pack/plugins/observability/server/services/slo/summary_transform/__snapshots__/summary_transform_installer.test.ts.snap generated
View file

@ -58,7 +58,7 @@ Array [
"goodEvents": "goodEvents",
"totalEvents": "totalEvents",
},
"script": "if (params.totalEvents == 0) { return -1 } else { return params.goodEvents / params.totalEvents }",
"script": "if (params.totalEvents == 0) { return -1 } else if (params.goodEvents >= params.totalEvents) { return 1 } else { return params.goodEvents / params.totalEvents }",
},
},
"statusCode": Object {
@ -286,7 +286,7 @@ Array [
"goodEvents": "goodEvents",
"totalEvents": "totalEvents",
},
"script": "if (params.totalEvents == 0) { return -1 } else { return params.goodEvents / params.totalEvents }",
"script": "if (params.totalEvents == 0) { return -1 } else if (params.goodEvents >= params.totalEvents) { return 1 } else { return params.goodEvents / params.totalEvents }",
},
},
"statusCode": Object {
@ -514,7 +514,7 @@ Array [
"goodEvents": "goodEvents",
"totalEvents": "totalEvents",
},
"script": "if (params.totalEvents == 0) { return -1 } else { return params.goodEvents / params.totalEvents }",
"script": "if (params.totalEvents == 0) { return -1 } else if (params.goodEvents >= params.totalEvents) { return 1 } else { return params.goodEvents / params.totalEvents }",
},
},
"statusCode": Object {
@ -757,7 +757,7 @@ Array [
"goodEvents": "goodEvents",
"totalEvents": "totalEvents",
},
"script": "if (params.totalEvents == 0) { return -1 } else { return params.goodEvents / params.totalEvents }",
"script": "if (params.totalEvents == 0) { return -1 } else if (params.goodEvents >= params.totalEvents) { return 1 } else { return params.goodEvents / params.totalEvents }",
},
},
"statusCode": Object {
@ -1013,7 +1013,7 @@ Array [
"goodEvents": "goodEvents",
"totalEvents": "totalEvents",
},
"script": "if (params.totalEvents == 0) { return -1 } else { return params.goodEvents / params.totalEvents }",
"script": "if (params.totalEvents == 0) { return -1 } else if (params.goodEvents >= params.totalEvents) { return 1 } else { return params.goodEvents / params.totalEvents }",
},
},
"statusCode": Object {

2
x-pack/plugins/observability/server/services/slo/summary_transform/templates/summary_occurrences_30d_rolling.ts
View file

@ -88,7 +88,7 @@ export const SUMMARY_OCCURRENCES_30D_ROLLING: TransformPutTransformRequest = {
totalEvents: 'totalEvents',
},
script:
'if (params.totalEvents == 0) { return -1 } else { return params.goodEvents / params.totalEvents }',
'if (params.totalEvents == 0) { return -1 } else if (params.goodEvents >= params.totalEvents) { return 1 } else { return params.goodEvents / params.totalEvents }',
},
},
errorBudgetInitial: {

2
x-pack/plugins/observability/server/services/slo/summary_transform/templates/summary_occurrences_7d_rolling.ts
View file

@ -88,7 +88,7 @@ export const SUMMARY_OCCURRENCES_7D_ROLLING: TransformPutTransformRequest = {
totalEvents: 'totalEvents',
},
script:
'if (params.totalEvents == 0) { return -1 } else { return params.goodEvents / params.totalEvents }',
'if (params.totalEvents == 0) { return -1 } else if (params.goodEvents >= params.totalEvents) { return 1 } else { return params.goodEvents / params.totalEvents }',
},
},
errorBudgetInitial: {

2
x-pack/plugins/observability/server/services/slo/summary_transform/templates/summary_occurrences_90d_rolling.ts
View file

@ -88,7 +88,7 @@ export const SUMMARY_OCCURRENCES_90D_ROLLING: TransformPutTransformRequest = {
totalEvents: 'totalEvents',
},
script:
'if (params.totalEvents == 0) { return -1 } else { return params.goodEvents / params.totalEvents }',
'if (params.totalEvents == 0) { return -1 } else if (params.goodEvents >= params.totalEvents) { return 1 } else { return params.goodEvents / params.totalEvents }',
},
},
errorBudgetInitial: {

2
x-pack/plugins/observability/server/services/slo/summary_transform/templates/summary_occurrences_monthly_aligned.ts
View file

@ -88,7 +88,7 @@ export const SUMMARY_OCCURRENCES_MONTHLY_ALIGNED: TransformPutTransformRequest =
totalEvents: 'totalEvents',
},
script:
'if (params.totalEvents == 0) { return -1 } else { return params.goodEvents / params.totalEvents }',
'if (params.totalEvents == 0) { return -1 } else if (params.goodEvents >= params.totalEvents) { return 1 } else { return params.goodEvents / params.totalEvents }',
},
},
errorBudgetInitial: {

2
x-pack/plugins/observability/server/services/slo/summary_transform/templates/summary_occurrences_weekly_aligned.ts
View file

@ -88,7 +88,7 @@ export const SUMMARY_OCCURRENCES_WEEKLY_ALIGNED: TransformPutTransformRequest =
totalEvents: 'totalEvents',
},
script:
'if (params.totalEvents == 0) { return -1 } else { return params.goodEvents / params.totalEvents }',
'if (params.totalEvents == 0) { return -1 } else if (params.goodEvents >= params.totalEvents) { return 1 } else { return params.goodEvents / params.totalEvents }',
},
},
errorBudgetInitial: {

2
x-pack/plugins/observability/server/services/slo/summary_transform/templates/summary_timeslices_30d_rolling.ts
View file

@ -88,7 +88,7 @@ export const SUMMARY_TIMESLICES_30D_ROLLING: TransformPutTransformRequest = {
totalEvents: 'totalEvents',
},
script:
'if (params.totalEvents == 0) { return -1 } else { return params.goodEvents / params.totalEvents }',
'if (params.totalEvents == 0) { return -1 } else if (params.goodEvents >= params.totalEvents) { return 1 } else { return params.goodEvents / params.totalEvents }',
},
},
errorBudgetInitial: {

2
x-pack/plugins/observability/server/services/slo/summary_transform/templates/summary_timeslices_7d_rolling.ts
View file

@ -88,7 +88,7 @@ export const SUMMARY_TIMESLICES_7D_ROLLING: TransformPutTransformRequest = {
totalEvents: 'totalEvents',
},
script:
'if (params.totalEvents == 0) { return -1 } else { return params.goodEvents / params.totalEvents }',
'if (params.totalEvents == 0) { return -1 } else if (params.goodEvents >= params.totalEvents) { return 1 } else { return params.goodEvents / params.totalEvents }',
},
},
errorBudgetInitial: {

2
x-pack/plugins/observability/server/services/slo/summary_transform/templates/summary_timeslices_90d_rolling.ts
View file

@ -88,7 +88,7 @@ export const SUMMARY_TIMESLICES_90D_ROLLING: TransformPutTransformRequest = {
totalEvents: 'totalEvents',
},
script:
'if (params.totalEvents == 0) { return -1 } else { return params.goodEvents / params.totalEvents }',
'if (params.totalEvents == 0) { return -1 } else if (params.goodEvents >= params.totalEvents) { return 1 } else { return params.goodEvents / params.totalEvents }',
},
},
errorBudgetInitial: {

2
x-pack/plugins/observability/server/services/slo/summary_transform/templates/summary_timeslices_monthly_aligned.ts
View file

@ -116,7 +116,7 @@ export const SUMMARY_TIMESLICES_MONTHLY_ALIGNED: TransformPutTransformRequest =
totalEvents: 'totalEvents',
},
script:
'if (params.totalEvents == 0) { return -1 } else { return params.goodEvents / params.totalEvents }',
'if (params.totalEvents == 0) { return -1 } else if (params.goodEvents >= params.totalEvents) { return 1 } else { return params.goodEvents / params.totalEvents }',
},
},
errorBudgetInitial: {

2
x-pack/plugins/observability/server/services/slo/summary_transform/templates/summary_timeslices_weekly_aligned.ts
View file

@ -101,7 +101,7 @@ export const SUMMARY_TIMESLICES_WEEKLY_ALIGNED: TransformPutTransformRequest = {
totalEvents: 'totalEvents',
},
script:
'if (params.totalEvents == 0) { return -1 } else { return params.goodEvents / params.totalEvents }',
'if (params.totalEvents == 0) { return -1 } else if (params.goodEvents >= params.totalEvents) { return 1 } else { return params.goodEvents / params.totalEvents }',
},
},
errorBudgetInitial: {