github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-23 17:28:26 -04:00
Code Issues Projects Releases Packages Wiki Activity

Fix failing test: X-Pack Saved Object Tagging Functional Tests.x-pack/test/saved_object_tagging/functional/tests/dashboard_integration·ts (#154191)

Browse source 
## Summary

Fix #154168

I having trouble recreating the error, but I suspect there could be an
issue with toggling the margins switch. The quick save button was still
disabled in the failing tests. Maybe the switch was already off by some
other test? Changing the description might be a better trigger for
unsaved changes.

[Flaky test runner x
200](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2066)
This commit is contained in:
Nick Peihl 2023-04-03 11:42:14 -04:00 • committed by GitHub
parent b5ba5d8add
commit affc44329b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

5
x-pack/test/saved_object_tagging/functional/tests/dashboard_integration.ts
View file

@ -17,8 +17,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
const dashboardSettings = getService('dashboardSettings');
const PageObjects = getPageObjects(['dashboard', 'tagManagement', 'common']);
// Failing: See https://github.com/elastic/kibana/issues/154168
describe.skip('dashboard integration', () => {
describe('dashboard integration', () => {
before(async () => {
await kibanaServer.importExport.load(
'x-pack/test/saved_object_tagging/common/fixtures/es_archiver/dashboard/data.json'
@ -164,7 +163,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
// edit and save dashboard
await PageObjects.dashboard.gotoDashboardEditMode('dashboard 4 with real data (tag-1)');
await PageObjects.dashboard.openSettingsFlyout();
await dashboardSettings.toggleUseMarginsBetweenPanels(false); // turn margins off to cause quicksave to be enabled
await dashboardSettings.setCustomPanelDescription('this should trigger unsaved changes'); // change description to cause quicksave to be enabled
await dashboardSettings.clickApplyButton();
await PageObjects.dashboard.clickQuickSave();