github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 09:48:58 -04:00
Code Issues Projects Releases Packages Wiki Activity

[8.8] [TSVB] Remove all usages of resetPage from tests (#156785) (#156865)

Browse source 
# Backport

This will backport the following commits from `main` to `8.8`:
- [[TSVB] Remove all usages of resetPage from tests
(#156785)](https://github.com/elastic/kibana/pull/156785)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Stratoula
Kalafateli","email":"efstratia.kalafateli@elastic.co"},"sourceCommit":{"committedDate":"2023-05-05T13:47:50Z","message":"[TSVB]
Remove all usages of resetPage from tests (#156785)\n\n##
Summary\r\n\r\nCloses
https://github.com/elastic/kibana/issues/156705\r\nCloses
https://github.com/elastic/kibana/issues/156796\r\n\r\nRemoves all the
visualBuilder.resetPage() usages as they are
flaky.","sha":"589e21b0d2827ef535dc293d79c06855fd79b837","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:TSVB","Team:Visualizations","failed-test","release_note:skip","backport:prev-minor","v8.8.0","v8.9.0"],"number":156785,"url":"https://github.com/elastic/kibana/pull/156785","mergeCommit":{"message":"[TSVB]
Remove all usages of resetPage from tests (#156785)\n\n##
Summary\r\n\r\nCloses
https://github.com/elastic/kibana/issues/156705\r\nCloses
https://github.com/elastic/kibana/issues/156796\r\n\r\nRemoves all the
visualBuilder.resetPage() usages as they are
flaky.","sha":"589e21b0d2827ef535dc293d79c06855fd79b837"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156785","number":156785,"mergeCommit":{"message":"[TSVB]
Remove all usages of resetPage from tests (#156785)\n\n##
Summary\r\n\r\nCloses
https://github.com/elastic/kibana/issues/156705\r\nCloses
https://github.com/elastic/kibana/issues/156796\r\n\r\nRemoves all the
visualBuilder.resetPage() usages as they are
flaky.","sha":"589e21b0d2827ef535dc293d79c06855fd79b837"}}]}]
BACKPORT-->

Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
This commit is contained in:
Kibana Machine 2023-05-05 10:54:59 -04:00 • committed by GitHub
parent 772c00c87e
commit b02e35daf9
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
6 changed files with 8 additions and 27 deletions
Download patch file Download diff file Expand all files Collapse all files

5
test/functional/apps/visualize/group4/_tsvb_chart.ts
View file

@ -41,10 +41,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
{ skipBrowserRefresh: true }
);
await visualize.navigateToNewVisualization();
await visualize.clickVisualBuilder();
await visualBuilder.checkVisualBuilderIsPresent();
await visualBuilder.setTime();
await visualBuilder.resetPage();
});
describe('metric', () => {

5
test/functional/apps/visualize/group6/_tsvb_markdown.ts
View file

@ -151,10 +151,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
describe('applying field formats from Advanced Settings for values', () => {
before(async () => {
await visualize.navigateToNewVisualization();
await visualize.clickVisualBuilder();
await visualBuilder.checkVisualBuilderIsPresent();
await visualBuilder.setTime();
await visualBuilder.resetPage();
await visualBuilder.clickMarkdown();
await visualBuilder.markdownSwitchSubTab('markdown');
await visualBuilder.enterMarkdown('{{ average_of_bytes.last.formatted }}');

5
test/functional/apps/visualize/group6/_tsvb_table.ts
View file

@ -26,10 +26,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
});
describe('table', () => {
beforeEach(async () => {
await visualize.navigateToNewVisualization();
await visualize.clickVisualBuilder();
await visualBuilder.checkVisualBuilderIsPresent();
await visualBuilder.setTime('Sep 22, 2015 @ 06:00:00.000', 'Sep 22, 2015 @ 11:00:00.000');
await visualBuilder.resetPage('Sep 22, 2015 @ 06:00:00.000', 'Sep 22, 2015 @ 11:00:00.000');
await visualBuilder.clickTable();
await visualBuilder.checkTableTabIsPresent();

7
test/functional/apps/visualize/group6/_tsvb_tsdb_basic.ts
View file

@ -11,7 +11,7 @@ import expect from '@kbn/expect';
import { FtrProviderContext } from '../../../ftr_provider_context';
export default function ({ getPageObjects, getService }: FtrProviderContext) {
const { visualBuilder, visualize } = getPageObjects(['visualBuilder', 'visualize']);
const { visualBuilder } = getPageObjects(['visualBuilder']);
const log = getService('log');
const kibanaServer = getService('kibanaServer');
const esArchiver = getService('esArchiver');
@ -43,10 +43,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
});
beforeEach(async () => {
await visualize.navigateToNewVisualization();
await visualize.clickVisualBuilder();
await visualBuilder.checkVisualBuilderIsPresent();
await visualBuilder.setTime();
await visualBuilder.resetPage();
});
it('should render from a tsdb dataView regular fields with no issues', async () => {

10
test/functional/page_objects/visual_builder_page.ts
View file

@ -34,20 +34,16 @@ export class VisualBuilderPageObject extends FtrService {
private readonly header = this.ctx.getPageObject('header');
private readonly timePicker = this.ctx.getPageObject('timePicker');
private readonly visChart = this.ctx.getPageObject('visChart');
private readonly visualize = this.ctx.getPageObject('visualize');
public async resetPage(
fromTime = 'Sep 19, 2015 @ 06:31:44.000',
toTime = 'Sep 22, 2015 @ 18:31:44.000'
) {
await this.common.navigateToUrl('visualize', 'create?type=metrics', {
useActualUrl: true,
});
this.log.debug('Wait for initializing TSVB editor');
await this.visualize.navigateToNewVisualization();
await this.visualize.clickVisualBuilder();
await this.checkVisualBuilderIsPresent();
this.log.debug('Set absolute time range from "' + fromTime + '" to "' + toTime + '"');
await this.setTime(fromTime, toTime);
// 2 sec sleep until https://github.com/elastic/kibana/issues/46353 is fixed
await this.common.sleep(2000);
}
public async setTime(

3
x-pack/test/functional/apps/lens/open_in_lens/tsvb/dashboard.ts
View file

@ -31,9 +31,6 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
});
it('should convert a by value TSVB viz to a Lens viz', async () => {
await visualize.navigateToNewVisualization();
await visualize.clickVisualBuilder();
await visualBuilder.checkVisualBuilderIsPresent();
await visualBuilder.resetPage();
await testSubjects.click('visualizeSaveButton');