github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-23 17:28:26 -04:00
Code Issues Projects Releases Packages Wiki Activity

[ui/vis_maps/tests] avoid boolean assertions for better error messages

Browse source
This commit is contained in:
spalger 2017-01-04 13:39:53 -07:00
parent 52d35fb108
commit b118a074c2
2 changed files with 15 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/ui/public/vis_maps/__tests__/tile_maps/tilemap_settings.js
View file

@ -22,12 +22,12 @@ describe('tilemaptest - TileMapSettingsTests-deprecated', function () {
it('should get url', async function () {
const mapUrl = tilemapSettings.getUrl();
expect(mapUrl.indexOf('{x}') > -1).to.be.ok();
expect(mapUrl.indexOf('{y}') > -1).to.be.ok();
expect(mapUrl.indexOf('{z}') > -1).to.be.ok();
expect(mapUrl).to.contain('{x}');
expect(mapUrl).to.contain('{y}');
expect(mapUrl).to.contain('{z}');
const urlObject = url.parse(mapUrl, true);
expect(urlObject.host.endsWith('elastic.co')).to.be.ok();
expect(urlObject.host).to.match(/elastic.co$/);
expect(urlObject.query).to.have.property('my_app_name');
expect(urlObject.query).to.have.property('my_app_version');
expect(urlObject.query).to.have.property('elastic_tile_service_tos');

24
src/ui/public/vis_maps/__tests__/tile_maps/tilemap_settings_mocked.js
View file

@ -63,22 +63,22 @@ describe('tilemaptest - TileMapSettingsTests-mocked', function () {
it('should get url', async function () {
const mapUrl = tilemapSettings.getUrl();
expect(mapUrl.indexOf('{x}') > -1).to.be.ok();
expect(mapUrl.indexOf('{y}') > -1).to.be.ok();
expect(mapUrl.indexOf('{z}') > -1).to.be.ok();
expect(mapUrl).to.contain('{x}');
expect(mapUrl).to.contain('{y}');
expect(mapUrl).to.contain('{z}');
const urlObject = url.parse(mapUrl, true);
expect(urlObject.host.endsWith('elastic.co')).to.be.ok();
expect(urlObject.query).to.have.property('my_app_name');
expect(urlObject.query).to.have.property('elastic_tile_service_tos');
expect(urlObject).to.have.property('hostname', 'proxy-tiles.elastic.co');
expect(urlObject.query).to.have.property('my_app_name', 'kibana');
expect(urlObject.query).to.have.property('elastic_tile_service_tos', 'agree');
});
it('should get options', async function () {
const options = tilemapSettings.getOptions();
expect(options).to.have.property('minZoom');
expect(options).to.have.property('maxZoom');
expect(options).to.have.property('attribution');
expect(options).to.have.property('minZoom', 0);
expect(options).to.have.property('maxZoom', 12);
expect(options).to.have.property('attribution').contain('©'); // html entity for ©, ensures that attribution is escaped
});
});
@ -100,10 +100,8 @@ describe('tilemaptest - TileMapSettingsTests-mocked', function () {
const mapUrl = tilemapSettings.getUrl();
const urlObject = url.parse(mapUrl, true);
expect(urlObject.query).to.have.property('foo');
expect(urlObject.query).to.have.property('bar');
expect(urlObject.query.foo).to.equal('tstool');
expect(urlObject.query.bar).to.equal('stool');
expect(urlObject.query).to.have.property('foo', 'tstool');
expect(urlObject.query).to.have.property('bar', 'stool');
});