github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-23 09:19:04 -04:00
Code Issues Projects Releases Packages Wiki Activity

[Ops] Make unit-test agent agnostic (#174441)

Browse source 
## Summary
This is not an error now but will be required for
https://github.com/elastic/kibana-operations/issues/15 - this solution
should work in both scenarios, so it can be done up-front.

Quote from Brian's notes regarding buildkite migration:
>The buildkite-agent process is running with a different umask in the
new system. Files are being created with slightly different permissions
by default. For example, when the kibana repo is checked out, files have
664 permissions instead of 644. This shouldn’t cause any major issues
for Kibana, BUT a few tests check the permission flags on files during a
copy process. They should probably be changed to check the permissions
on the source file rather than just hard-coding them.

This is showing up in the unit tests like this: 
```
FAIL  src/cli_plugin/install/zip.test.js
--
  | ● kibana cli › zip › checkFilePermission › verify consistency of modes of files
  |  
  | expect(received).toEqual(expected) // deep equality
  |  
  | Expected: "755"
  | Received: "775"
```

We can't access the source files inside the zip file, the rights will
only be revealed after unzipping. However, the difference in the default
access rights is in the RW and not the X, which we're really curious
about.

So as a solution, I'm only checking if the executable file is indeed
executable by all, and the non-executable is not executable by anyone.
This commit is contained in:
Alex Szabo 2024-01-09 10:59:30 +01:00 • committed by GitHub
parent 51e0c0ffde
commit b15266844b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

7
src/cli_plugin/install/zip.test.js
View file

@ -15,7 +15,8 @@ import globby from 'globby';
import { analyzeArchive, extractArchive } from './zip';
const getMode = (path) => (fs.statSync(path).mode & parseInt('777', 8)).toString(8);
const getExecFlags = (path) =>
(fs.statSync(path).mode & parseInt('111', 8)).toString(8).padStart(3, '0');
describe('kibana cli', function () {
describe('zip', function () {
@ -83,8 +84,8 @@ describe('kibana cli', function () {
]
`);
expect(getMode(path.resolve(tempPath, 'executable'))).toEqual('755');
expect(getMode(path.resolve(tempPath, 'not-executable'))).toEqual('644');
expect(getExecFlags(path.resolve(tempPath, 'executable'))).toEqual('111');
expect(getExecFlags(path.resolve(tempPath, 'not-executable'))).toEqual('000');
});
});