github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 09:48:58 -04:00
Code Issues Projects Releases Packages Wiki Activity

[TSVB] Replace missing icon with EUI one (#172661)

Browse source 
## Summary

Fixes #167949 

Replaces missing font-awesome icon with the correct EUI one:

<img width="890" alt="Screenshot 2023-12-06 at 11 12 20"
src="4167c4e6-c8b3-4952-8f87-2874008a1f00">

As for the other icons in
`src/plugins/vis_types/timeseries/public/application/components/icon_select/icon_select.js`
they are correctly mapped into EUI ones via these lines:
594337a099/src/plugins/vis_types/timeseries/public/application/components/icon_select/icon_select.js (L87-L90)

As of removing completely `font-awesome` I can still see some usage in
`x-pack/plugins/monitoring/public/components/sparkline/index.js` despite
not having the css imported (so I suspect those icons are actually not
rendered cc @elastic/obs-ux-infra_services-team )
This commit is contained in:
Marco Liberati 2023-12-06 17:56:33 +01:00 • committed by GitHub
parent 45cbd2b743
commit b1c7372083
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 10 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

12
src/plugins/vis_types/timeseries/public/application/components/vis_editor_visualization.js
View file

@ -8,7 +8,15 @@
import PropTypes from 'prop-types';
import React, { Component } from 'react';
import { keys, EuiFlexGroup, EuiFlexItem, EuiButton, EuiText, EuiSwitch } from '@elastic/eui';
import {
keys,
EuiFlexGroup,
EuiIcon,
EuiFlexItem,
EuiButton,
EuiText,
EuiSwitch,
} from '@elastic/eui';
import { FormattedMessage, injectI18n } from '@kbn/i18n-react';
import { pluck } from 'rxjs/operators';
@ -200,7 +208,7 @@ class VisEditorVisualizationUI extends Component {
defaultMessage: 'Press up/down to adjust the chart size',
})}
>
<i className="fa fa-ellipsis-h" />
<EuiIcon type="grab" />
</button>
</div>
</div>