github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-23 01:13:23 -04:00
Code Issues Projects Releases Packages Wiki Activity

[ML] Correctly transfer dedicated index setting to advanced job page (#18899)

Browse source 
* [ML] Correcly transfer dedicated index setting to advanced job page

* removing accidentally added code
This commit is contained in:
James Gowdy 2018-05-08 13:50:00 +01:00 • committed by GitHub
parent 59fb742f80
commit b1ca716b80
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 15 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

22
x-pack/plugins/ml/public/jobs/new_job/advanced/new_job_controller.js
View file

@ -216,13 +216,28 @@ module.controller('MlNewJob',
console.log('Editing job', mlJobService.currentJob);
$scope.ui.pageTitle = 'Editing Job ' + $scope.job.job_id;
} else {
// if the job_version is undefined, assume we have transferred to this page from
// a new job wizard.
// Alternatively, we are cloning a job and so the job already has a job_version
if (mlJobService.currentJob.job_version === undefined) {
$scope.mode = MODE.NEW;
// if results_index_name exists, the dedicated index checkbox has been checked
if ($scope.job.results_index_name !== undefined) {
$scope.ui.useDedicatedIndex = true;
}
} else {
$scope.mode = MODE.CLONE;
console.log('Cloning job', mlJobService.currentJob);
$scope.ui.pageTitle = 'Clone Job from ' + $scope.job.job_id;
$scope.job.job_id = '';
if ($scope.job.results_index_name === 'shared') {
delete $scope.job.results_index_name;
} else {
$scope.ui.useDedicatedIndex = true;
$scope.job.results_index_name = '';
}
}
setDatafeedUIText();
setFieldDelimiterControlsFromText();
@ -237,13 +252,6 @@ module.controller('MlNewJob',
if ($scope.job.analysis_limits && $scope.job.analysis_limits.model_memory_limit) {
$scope.ui.modelMemoryLimitText = $scope.job.analysis_limits.model_memory_limit;
}
if ($scope.job.results_index_name === 'shared') {
delete $scope.job.results_index_name;
} else {
$scope.ui.useDedicatedIndex = true;
$scope.job.results_index_name = '';
}
}
// clear the current job