github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 09:48:58 -04:00
Code Issues Projects Releases Packages Wiki Activity

[Guided onboarding] Fix the value of data-test-subj for telemetry (#154462)

Browse source 
## Summary
This PR changes the value of `data-test-subj` on the landing page to fix
the telemetry for guided onboarding. In the code, this attribute is only
used for testing.

More details in https://github.com/elastic/telemetry/issues/2155.
This commit is contained in:
Yulia Čech 2023-04-06 11:35:12 +02:00 • committed by GitHub
parent cc52e132f3
commit b2812f3278
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/plugins/home/public/application/components/guided_onboarding/getting_started.tsx
View file

@ -205,7 +205,7 @@ export const GettingStarted = () => {
<EuiPageTemplate.Section
alignment="center"
css={paddingCss}
data-test-subj="onboarding--landing-page"
data-test-subj="guided-onboarding--landing-page"
>
<EuiTitle size="l" className="eui-textCenter">
<h1>{title}</h1>

2
test/functional/page_objects/home_page.ts
View file

@ -57,7 +57,7 @@ export class HomePageObject extends FtrService {
}
async isGuidedOnboardingLandingDisplayed() {
return await this.testSubjects.isDisplayed('onboarding--landing-page');
return await this.testSubjects.isDisplayed('guided-onboarding--landing-page');
}
async isHomePageDisplayed() {