github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 09:48:58 -04:00
Code Issues Projects Releases Packages Wiki Activity

[8.x] [Search] Fix autogenerated connector names (#197585) (#197769)

Browse source 
# Backport

This will backport the following commits from `main` to `8.x`:
- [[Search] Fix autogenerated connector names
(#197585)](https://github.com/elastic/kibana/pull/197585)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Navarone
Feekery","email":"13634519+navarone-feekery@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-10-25T07:53:16Z","message":"[Search]
Fix autogenerated connector names (#197585)\n\nImprove the autogenerated
connector names by\r\n\r\n- Re-generating names when changing connector
source\r\n- Preventing editing of names after connector is
created","sha":"c05e1c58ab7677bf082dc11da040a0c3be4d6498","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","v9.0.0","Team:Search","backport:prev-major","v8.16.0","v8.17.0"],"title":"[Search]
Fix autogenerated connector
names","number":197585,"url":"https://github.com/elastic/kibana/pull/197585","mergeCommit":{"message":"[Search]
Fix autogenerated connector names (#197585)\n\nImprove the autogenerated
connector names by\r\n\r\n- Re-generating names when changing connector
source\r\n- Preventing editing of names after connector is
created","sha":"c05e1c58ab7677bf082dc11da040a0c3be4d6498"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197585","number":197585,"mergeCommit":{"message":"[Search]
Fix autogenerated connector names (#197585)\n\nImprove the autogenerated
connector names by\r\n\r\n- Re-generating names when changing connector
source\r\n- Preventing editing of names after connector is
created","sha":"c05e1c58ab7677bf082dc11da040a0c3be4d6498"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Navarone Feekery <13634519+navarone-feekery@users.noreply.github.com>
This commit is contained in:
Kibana Machine 2024-10-25 20:32:28 +11:00 • committed by GitHub
parent a7b19ba22e
commit b2d554e253
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 2 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

1
x-pack/plugins/enterprise_search/public/applications/enterprise_search_content/components/connectors/create_connector/start_step.tsx
View file

@ -106,6 +106,7 @@ export const StartStep: React.FC<StartStepProps> = ({
name="first"
value={rawName}
onChange={handleNameChange}
disabled={!!connector}
onBlur={() => {
if (selectedConnector) {
generateConnectorName({

5
x-pack/plugins/enterprise_search/public/applications/enterprise_search_content/components/new_index/method_connector/new_connector_logic.ts
View file

@ -143,9 +143,7 @@ export const NewConnectorLogic = kea<MakeLogicType<NewConnectorValues, NewConnec
}
},
connectorNameGenerated: ({ connectorName }) => {
if (!values.rawName) {
actions.setRawName(connectorName);
}
actions.setRawName(connectorName);
},
createConnector: ({
isSelfManaged,
@ -191,7 +189,6 @@ export const NewConnectorLogic = kea<MakeLogicType<NewConnectorValues, NewConnec
setSelectedConnector: ({ connector }) => {
if (connector) {
actions.generateConnectorName({
connectorName: values.rawName,
connectorType: connector.serviceType,
});
}