github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 01:38:56 -04:00
Code Issues Projects Releases Packages Wiki Activity

Fix visualization migration when savedSearchId is empty string (#40172) (#40209)

Browse source 
* Fix visualization migration when savedSearchId is empty string

* Apply PR feedback

* Apply PR feedback pt2
This commit is contained in:
Mike Côté 2019-07-02 20:45:53 -04:00 • committed by GitHub
parent f68b5a1edb
commit b41e82fcde
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 27 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/legacy/core_plugins/kibana/migrations/migrations.js
View file

@ -412,8 +412,8 @@ export const migrations = {
id: savedSearchId,
});
doc.attributes.savedSearchRefName = 'search_0';
delete doc.attributes.savedSearchId;
}
delete doc.attributes.savedSearchId;
// Migrate controls
const visStateJSON = get(doc, 'attributes.visState');

26
src/legacy/core_plugins/kibana/migrations/migrations.test.js
View file

@ -572,6 +572,32 @@ Object {
`);
});
it('delete savedSearchId when empty string in doc', () => {
const doc = {
id: '1',
attributes: {
visState: '{}',
kibanaSavedObjectMeta: {
searchSourceJSON: '{}',
},
savedSearchId: '',
},
};
const migratedDoc = migrate(doc);
expect(migratedDoc).toMatchInlineSnapshot(`
Object {
"attributes": Object {
"kibanaSavedObjectMeta": Object {
"searchSourceJSON": "{}",
},
"visState": "{}",
},
"id": "1",
"references": Array [],
}
`);
});
it('should return a new object if vis is table and has multiple split aggs', () => {
const aggs = [
{