github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 17:59:23 -04:00
Code Issues Projects Releases Packages Wiki Activity

[ES|QL] Removes CCS check from the editor (#194903)

Browse source 
## Summary

Removes the CCS check from the editor. We support now cross cluster
queries so this was a leftover. I also tested it with the oblt clusters
to ensure that our validation works as expected.
This commit is contained in:
Stratoula Kalafateli 2024-10-07 16:33:56 +02:00 • committed by GitHub
parent ad986d4c26
commit b4ba131409
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 16 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

3
packages/kbn-esql-validation-autocomplete/src/shared/helpers.ts
View file

@ -548,9 +548,6 @@ export function isVariable(
): column is ESQLVariable {
return Boolean(column && 'location' in column);
}
export function hasCCSSource(name: string) {
return name.includes(':');
}
/**
* This will return the name without any quotes.

14
packages/kbn-esql-validation-autocomplete/src/validation/__tests__/test_suites/validation.command.from.ts
View file

@ -56,10 +56,12 @@ export const validationFromCommandTestSuite = (setup: helpers.Setup) => {
await expectErrors('fRoM in*ex', []);
await expectErrors('fRoM ind*ex', []);
await expectErrors('fRoM *,-.*', []);
await expectErrors('fRoM remote-*:indexes*', []);
await expectErrors('fRoM remote-*:indexes', []);
await expectErrors('fRoM remote-ccs:indexes', []);
await expectErrors('fRoM a_index, remote-ccs:indexes', []);
await expectErrors('fRoM remote-*:indexes*', ['Unknown index [remote-*:indexes*]']);
await expectErrors('fRoM remote-*:indexes', ['Unknown index [remote-*:indexes]']);
await expectErrors('fRoM remote-ccs:indexes', ['Unknown index [remote-ccs:indexes]']);
await expectErrors('fRoM a_index, remote-ccs:indexes', [
'Unknown index [remote-ccs:indexes]',
]);
await expectErrors('fRoM .secret_index', []);
await expectErrors('from my-index', []);
});
@ -151,12 +153,12 @@ export const validationFromCommandTestSuite = (setup: helpers.Setup) => {
);
await expectErrors(
`from remote-ccs:indexes ${setWrapping('METADATA _id')}`,
[],
['Unknown index [remote-ccs:indexes]'],
addBracketsWarning()
);
await expectErrors(
`from *:indexes ${setWrapping('METADATA _id')}`,
[],
['Unknown index [*:indexes]'],
addBracketsWarning()
);
});

12
packages/kbn-esql-validation-autocomplete/src/validation/__tests__/test_suites/validation.command.metrics.ts
View file

@ -51,10 +51,14 @@ export const validationMetricsCommandTestSuite = (setup: helpers.Setup) => {
await expectErrors('metrics in*ex', []);
await expectErrors('metrics ind*ex', []);
await expectErrors('metrics *,-.*', []);
await expectErrors('metrics remote-*:indexes*', []);
await expectErrors('metrics remote-*:indexes', []);
await expectErrors('metrics remote-ccs:indexes', []);
await expectErrors('metrics a_index, remote-ccs:indexes', []);
await expectErrors('metrics remote-*:indexes*', ['Unknown index [remote-*:indexes*]']);
await expectErrors('metrics remote-*:indexes', ['Unknown index [remote-*:indexes]']);
await expectErrors('metrics remote-ccs:indexes', [
'Unknown index [remote-ccs:indexes]',
]);
await expectErrors('metrics a_index, remote-ccs:indexes', [
'Unknown index [remote-ccs:indexes]',
]);
await expectErrors('metrics .secret_index', []);
});

6
packages/kbn-esql-validation-autocomplete/src/validation/validation.ts
View file

@ -47,7 +47,6 @@ import {
sourceExists,
getColumnExists,
hasWildcard,
hasCCSSource,
isSettingItem,
isAssignment,
isVariable,
@ -815,11 +814,6 @@ function validateSource(
return messages;
}
const hasCCS = hasCCSSource(source.name);
if (hasCCS) {
return messages;
}
const commandDef = getCommandDefinition(commandName);
const isWildcardAndNotSupported =
hasWildcard(source.name) && !commandDef.signature.params.some(({ wildcards }) => wildcards);